Attention is currently required from: Hung-Te Lin, Jianjun Wang, Nico Huber, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78044?usp=email )
Change subject: soc/mediatek: PCI: Fix translation window
......................................................................
Patch Set 12:
(3 comments)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/78044/comment/c9b4931e_f980276e :
PS8, Line 174: __fls
We still need the 'size' to calculate addresses.
Right.
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/78044/comment/452ae6ed_d9e9748b :
PS12, Line 167: while (remaining && *count < PCIE_MAX_TRANS_TABLES) {
Add comment
```
/* The table size needs to be a power of 2.
In addition, cpu_addr needs to be aligned to the size. */
```
https://review.coreboot.org/c/coreboot/+/78044/comment/0bac00eb_b1412f36 :
PS12, Line 175: remaining
table
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78044?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I42b0f0bf9222d284dee0c29f1a6ed6366d6e6689
Gerrit-Change-Number: 78044
Gerrit-PatchSet: 12
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Thu, 28 Sep 2023 06:59:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-MessageType: comment