Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jakub Czapiga, Julius Werner, Nick Vaccaro, Nick Vaccaro, Yu-Ping Wu.
Hello Boris Mittelberg, Caveh Jalali, Jakub Czapiga, Julius Werner, Nick Vaccaro, Nick Vaccaro, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78076?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Code-Review+1 by Jakub Czapiga, Verified+1 by build bot (Jenkins)
Change subject: {lib, ec/google}: Add weak implementation for get_lid_switch() ......................................................................
{lib, ec/google}: Add weak implementation for get_lid_switch()
This patch implements a weak get_lid_switch() function that returns 1 (aka LID open) unless overridden by a real implementation.
This is necessary for platforms that do not have the EC_GOOGLE_CHROMEEC_LPC config.
Additionally, this function is now getting called twice in ramstage (once for lb_gpios and once by the GMA driver), so cached the response from `get_lid_switch()` in a static local variable to avoid unnecessary overhead.
BUG=b:299137940 TEST=Able to build and boot google/rex.
Change-Id: I8847bc6f08f5d9cecf9d9ddaf33c44bd40491e98 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/ec/google/chromeec/switches.c M src/lib/bootmode.c 2 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/78076/3