Attention is currently required from: Kyösti Mälkki. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58896 )
Change subject: ChromeOS: Add legacy mainboard_ec_running_ro() ......................................................................
Patch Set 7:
(1 comment)
File src/vendorcode/google/chromeos/gnvs.c:
https://review.coreboot.org/c/coreboot/+/58896/comment/369d675e_442681b4 PS7, Line 67: }
I am asking the same question in pathcset #5, I don't know what should be done with this ACPI table […]
I think ideally it just keeps containing the same data it had on boot? None of the info here would change across S3 and need to be regenerated. I don't know how these ACPI tables work, do they have to be rewritten from scratch on resume or can you just keep the same table you had before suspend around? What does the existing code do?
-
Julius Werner (Code Review)