Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57315 )
Change subject: mb/google/guybrush: Update PCIe WWAN path for WWAN PCIe check ......................................................................
mb/google/guybrush: Update PCIe WWAN path for WWAN PCIe check
variant_has_pcie_wwan() was always coming back as disabled because find_dev_nested_path() couldn't find the device until the domain was added to the array.
BUG=b:193036827 TEST=Boot guybrush with PCIe & USB WWAN devices.
Signed-off-by: Martin Roth martinroth@chromium.org Change-Id: Id94fa0b0ff5c29fa447e869220d27ccfe61438c6 --- M src/mainboard/google/guybrush/variants/baseboard/helpers.c 1 file changed, 9 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/57315/1
diff --git a/src/mainboard/google/guybrush/variants/baseboard/helpers.c b/src/mainboard/google/guybrush/variants/baseboard/helpers.c index 5297a49..cde31c2 100644 --- a/src/mainboard/google/guybrush/variants/baseboard/helpers.c +++ b/src/mainboard/google/guybrush/variants/baseboard/helpers.c @@ -34,11 +34,15 @@ __weak bool variant_has_pcie_wwan(void) { static const struct device_path pcie_wwan_path[] = { - { - .type = DEVICE_PATH_PCI, - .pci.devfn = PCIE_GPP_2_2_DEVFN, - }, - }; + { + .type = DEVICE_PATH_DOMAIN, + .domain.domain = 0x0, + }, + { + .type = DEVICE_PATH_PCI, + .pci.devfn = WWAN_DEVFN + }, +};
return variant_has_device_enabled(pcie_wwan_path, ARRAY_SIZE(pcie_wwan_path)); }