Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant
......................................................................
Patch Set 8:
I've published the schematic of the latest adapter board here: https://nitrocaster.me/files/X230U_rev6_schematic.pdf
Hopefully this will help getting this merged.
Let me know what you guys think.
Thanks for sharing! It answers some questions and raises new :)
Most of all, I wonder what exactly U1 does and if it is necessary
at all if one controls the firmware. Is it simply translating the
BL_CTL_SYS signal to a different PWM frequency? or is it also
needed as a buffer? Also, what frequency does it expect on
BL_CTL_SYS, if any specific?
And, can you confirm that:
* With the default assembly, one can't control panel power via software.
* But by moving F1 to J1, it would become possible?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 8
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Herzog
Gerrit-CC: Holger Levsen
holger@layer-acht.org
Gerrit-CC: Kilian Neuner
cb@9-r.net
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Pavel Kovalenko
paul-kv@yandex.ru
Gerrit-CC: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-CC: Tom Hiller
thrilleratplay@gmail.com
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-Comment-Date: Mon, 16 Dec 2019 13:07:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment