Change in coreboot[master]: mb/google/dedede: remove unuse I2C1

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: [RFC]...

Alec Wang (Code Review)

16 Oct 2020 16 Oct '20

8:36 a.m.

Alec Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46486 )

Change subject: mb/google/dedede: remove unuse I2C1 ......................................................................

mb/google/dedede: remove unuse I2C1

remove unuse I2C1

BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten

Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I88b6f12728d9ae25882c141d6a8558f76591d3a2 --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 1 insertion(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46486/1

diff --git a/src/mainboard/google/dedede/variants/boten/overridetree.cb b/src/mainboard/google/dedede/variants/boten/overridetree.cb index 2ba6d9d..fd532d1 100644 --- a/src/mainboard/google/dedede/variants/boten/overridetree.cb +++ b/src/mainboard/google/dedede/variants/boten/overridetree.cb @@ -9,7 +9,6 @@ #| | for TPM communication | #| | before memory is up | #| I2C0 | Trackpad | - #| I2C1 | Digitizer | #| I2C2 | Touchscreen | #| I2C4 | Audio | #+-------------------+---------------------------+ @@ -21,9 +20,6 @@ .i2c[0] = { .speed = I2C_SPEED_FAST, }, - .i2c[1] = { - .speed = I2C_SPEED_FAST, - }, .i2c[2] = { .speed = I2C_SPEED_FAST, }, @@ -39,7 +35,7 @@

register "SerialIoI2cMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, - [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoDisabled, [PchSerialIoIndexI2C2] = PchSerialIoPci, [PchSerialIoIndexI2C3] = PchSerialIoDisabled, [PchSerialIoIndexI2C4] = PchSerialIoPci,

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Karthik Ramasubramanian (Code Review)

19 Oct 19 Oct

6:22 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46486 )

Change subject: mb/google/dedede: remove unuse I2C1 ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46486/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46486/1//COMMIT_MSG@7 PS1, Line 7: : mb/google/dedede/var/boten: Disable I2C1

I2C1 controller is unused and hence disabling it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88b6f12728d9ae25882c141d6a8558f76591d3a2 Gerrit-Change-Number: 46486 Gerrit-PatchSet: 1 Gerrit-Owner: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Mon, 19 Oct 2020 06:22:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Alec Wang (Code Review)

6:42 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/boten: Disable I2C1

Hello build bot (Jenkins), Marco Chen, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46486

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/boten: Disable I2C1 ......................................................................

mb/google/dedede/var/boten: Disable I2C1

I2C1 controller is unused and hence disabling it.

BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46486/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/46486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88b6f12728d9ae25882c141d6a8558f76591d3a2 Gerrit-Change-Number: 46486 Gerrit-PatchSet: 2 Gerrit-Owner: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-MessageType: newpatchset

Alec Wang (Code Review)

6:43 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/boten: Disable I2C1

Alec Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46486 )

Change subject: mb/google/dedede/var/boten: Disable I2C1 ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46486/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/46486/1//COMMIT_MSG@7 PS1, Line 7: :

...

mb/google/dedede/var/boten: Disable I2C1 […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/46486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88b6f12728d9ae25882c141d6a8558f76591d3a2 Gerrit-Change-Number: 46486 Gerrit-PatchSet: 2 Gerrit-Owner: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Mon, 19 Oct 2020 06:43:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Rasheed Hsueh (Code Review)

12 Nov 12 Nov

6:40 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/boten: Disable I2C1

Rasheed Hsueh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46486 )

Change subject: mb/google/dedede/var/boten: Disable I2C1 ......................................................................

Set Ready For Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/46486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88b6f12728d9ae25882c141d6a8558f76591d3a2 Gerrit-Change-Number: 46486 Gerrit-PatchSet: 3 Gerrit-Owner: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Thu, 12 Nov 2020 06:40:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rasheed Hsueh (Code Review)

6:44 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/boten: Disable I2C1

Rasheed Hsueh has uploaded a new patch set (#4) to the change originally created by Alec Wang. ( https://review.coreboot.org/c/coreboot/+/46486 )

Change subject: mb/google/dedede/var/boten: Disable I2C1 ......................................................................

mb/google/dedede/var/boten: Disable I2C1

I2C1 controller is unused and hence disabling it.

BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten

Signed-off-by: alec.wang alec.wang@lcfc.corp-partner.google.com Change-Id: I88b6f12728d9ae25882c141d6a8558f76591d3a2 Signed-off-by: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com --- M src/mainboard/google/dedede/variants/boten/overridetree.cb 1 file changed, 2 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46486/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/46486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88b6f12728d9ae25882c141d6a8558f76591d3a2 Gerrit-Change-Number: 46486 Gerrit-PatchSet: 4 Gerrit-Owner: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-MessageType: newpatchset

Rasheed Hsueh (Code Review)

6:46 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/boten: Disable I2C1

Rasheed Hsueh has uploaded a new patch set (#5) to the change originally created by Alec Wang. ( https://review.coreboot.org/c/coreboot/+/46486 )

Change subject: mb/google/dedede/var/boten: Disable I2C1 ......................................................................

mb/google/dedede/var/boten: Disable I2C1

I2C1 controller is unused and hence disabling it.

BUG=b:160664447 BRANCH=NONE TEST=build bios and verify theirs function for boten

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46486/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/46486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88b6f12728d9ae25882c141d6a8558f76591d3a2 Gerrit-Change-Number: 46486 Gerrit-PatchSet: 5 Gerrit-Owner: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-MessageType: newpatchset

Alec Wang (Code Review)

22 Jan 22 Jan

2 a.m.

New subject: Change in coreboot[master]: mb/google/dedede/var/boten: Disable I2C1

Alec Wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46486 )

Change subject: mb/google/dedede/var/boten: Disable I2C1 ......................................................................

Abandoned

no need anymore

-- To view, visit https://review.coreboot.org/c/coreboot/+/46486 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88b6f12728d9ae25882c141d6a8558f76591d3a2 Gerrit-Change-Number: 46486 Gerrit-PatchSet: 5 Gerrit-Owner: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Marco Chen marcochen@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-MessageType: abandon

1408

days inactive

1506

days old

coreboot-gerrit@coreboot.org

7 comments

3 participants

tags (0)

participants (3)

Alec Wang (Code Review)
Karthik Ramasubramanian (Code Review)
Rasheed Hsueh (Code Review)