Attention is currently required from: Jianeng Ceng, Kapil Porwal, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81788?usp=email )
Change subject: drivers/i2c/generic: Add i2c_generic_write_gpio for public
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/81788/comment/ed9fbc92_9a614782 :
PS1, Line 31: int i2c_generic_write_gpio(struct acpi_gpio *gpio, int *curr_index)
: {
: int ret = -1;
:
: if (gpio->pin_count == 0)
: return ret;
:
: acpi_device_write_gpio(gpio);
: ret = *curr_index;
: (*curr_index)++;
:
: return ret;
: }
I think this function can be copied to the new driver instead of making it public. […]
If you consider the name we can change it. Or move to acpi.c or somewhere else.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81788?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Gerrit-Change-Number: 81788
Gerrit-PatchSet: 1
Gerrit-Owner: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 15 Apr 2024 02:09:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment