Attention is currently required from: David Wu, Karthik Ramasubramanian, Kenneth Chan, Subrata Banik.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/85107?usp=email )
Change subject: mb/google/brox/var/jubilant: Add fw_config for WWAN Sar Sensor ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85107/comment/ad7f9a21_284f14aa?usp... : PS2, Line 10: remvoed
Nit: removed
fixed.
https://review.coreboot.org/c/coreboot/+/85107/comment/b29a6dde_0e05fa6f?usp... : PS2, Line 18: to
Nit: remove 'to'
fixed.
File src/mainboard/google/brox/variants/jubilant/smihandler.c:
https://review.coreboot.org/c/coreboot/+/85107/comment/76b93ba0_6122d2fa?usp... : PS2, Line 16: if (slp_typ == ACPI_S5) { : if (!fw_config_probe(FW_CONFIG(DB_USB, DB_1A))) {
I would recommend to check specifically for LTE and LTE SAR config. […]
fixed.
File src/mainboard/google/brox/variants/jubilant/variant.c:
https://review.coreboot.org/c/coreboot/+/85107/comment/27b276a6_eb5f8270?usp... : PS2, Line 41: if (!fw_config_probe(FW_CONFIG(DB_USB, DB_1A))) {
Same comment as in the other file: […]
fixed.