Change in coreboot[master]: ec/google/chromeec: Replace uses of ec_current_image with ec_image
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40267 )
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
ec/google/chromeec: Replace uses of ec_current_image with ec_image
This change replaces all uses of ec_current_image with ec_image since Chromium OS EC has deprecated the use of enum ec_current_image and instead changed it to enum ec_image.
BUG=b:149987779
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I7e45ea6c736b44040561f0f8a80f817ade8db864 --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40267/1
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 8bb3661..8d9c2ac 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -1337,9 +1337,9 @@ }
/* Cache and retrieve the EC image type (ro or rw) */ -enum ec_current_image google_chromeec_get_current_image(void) +enum ec_image google_chromeec_get_current_image(void) { - MAYBE_STATIC_BSS enum ec_current_image ec_image_type = EC_IMAGE_UNKNOWN; + MAYBE_STATIC_BSS enum ec_image ec_image_type = EC_IMAGE_UNKNOWN;
if (ec_image_type != EC_IMAGE_UNKNOWN) return ec_image_type; diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index c40172a..f1caeb0 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -25,7 +25,7 @@ /* Check if EC supports feature EC_FEATURE_UNIFIED_WAKE_MASKS */ bool google_chromeec_is_uhepi_supported(void); int google_ec_running_ro(void); -enum ec_current_image google_chromeec_get_current_image(void); +enum ec_image google_chromeec_get_current_image(void); void google_chromeec_init(void); int google_chromeec_pd_get_amode(uint16_t svid); int google_chromeec_wait_for_displayport(long timeout);
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40267 )
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40267/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40267/1//COMMIT_MSG@11 PS1, Line 11: instead changed it to enum ec_image. A reference to that Chrome EC commit would be nice.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40267 )
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40267 )
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Tim Wawrzynczak, Paul Menzel, Jett Rink, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40267
to look at the new patch set (#2).
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
ec/google/chromeec: Replace uses of ec_current_image with ec_image
This change replaces all uses of ec_current_image with ec_image since Chromium OS EC has deprecated(sha 78d1ed61d) the use of enum ec_current_image and instead changed it to enum ec_image.
BUG=b:149987779
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I7e45ea6c736b44040561f0f8a80f817ade8db864 --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40267/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40267 )
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40267/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40267/1//COMMIT_MSG@11 PS1, Line 11: instead changed it to enum ec_image.
A reference to that Chrome EC commit would be nice.
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40267 )
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40267/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40267/2//COMMIT_MSG@10 PS2, Line 10: deprecated(sha 78d1ed61d) Please add a space before the (.
Hello build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, Jett Rink, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40267
to look at the new patch set (#3).
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
ec/google/chromeec: Replace uses of ec_current_image with ec_image
This change replaces all uses of ec_current_image with ec_image since Chromium OS EC has deprecated (sha 78d1ed61d) the use of enum ec_current_image and instead changed it to enum ec_image.
BUG=b:149987779
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I7e45ea6c736b44040561f0f8a80f817ade8db864 --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/40267/3
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40267 )
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40267/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40267/2//COMMIT_MSG@10 PS2, Line 10: deprecated(sha 78d1ed61d)
Please add a space before the (.
Done
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40267 )
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
ec/google/chromeec: Replace uses of ec_current_image with ec_image
This change replaces all uses of ec_current_image with ec_image since Chromium OS EC has deprecated (sha 78d1ed61d) the use of enum ec_current_image and instead changed it to enum ec_image.
BUG=b:149987779
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: I7e45ea6c736b44040561f0f8a80f817ade8db864 Reviewed-on: https://review.coreboot.org/c/coreboot/+/40267 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/ec/google/chromeec/ec.c M src/ec/google/chromeec/ec.h 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c index 8bb3661..8d9c2ac 100644 --- a/src/ec/google/chromeec/ec.c +++ b/src/ec/google/chromeec/ec.c @@ -1337,9 +1337,9 @@ }
/* Cache and retrieve the EC image type (ro or rw) */ -enum ec_current_image google_chromeec_get_current_image(void) +enum ec_image google_chromeec_get_current_image(void) { - MAYBE_STATIC_BSS enum ec_current_image ec_image_type = EC_IMAGE_UNKNOWN; + MAYBE_STATIC_BSS enum ec_image ec_image_type = EC_IMAGE_UNKNOWN;
if (ec_image_type != EC_IMAGE_UNKNOWN) return ec_image_type; diff --git a/src/ec/google/chromeec/ec.h b/src/ec/google/chromeec/ec.h index c40172a..f1caeb0 100644 --- a/src/ec/google/chromeec/ec.h +++ b/src/ec/google/chromeec/ec.h @@ -25,7 +25,7 @@ /* Check if EC supports feature EC_FEATURE_UNIFIED_WAKE_MASKS */ bool google_chromeec_is_uhepi_supported(void); int google_ec_running_ro(void); -enum ec_current_image google_chromeec_get_current_image(void); +enum ec_image google_chromeec_get_current_image(void); void google_chromeec_init(void); int google_chromeec_pd_get_amode(uint16_t svid); int google_chromeec_wait_for_displayport(long timeout);
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40267 )
Change subject: ec/google/chromeec: Replace uses of ec_current_image with ec_image ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2207 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2206 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2205
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Furquan Shaikh (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)