Change in ...coreboot[master]: Makefile: Use -Wold-style-definition

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

22 Jun 2019 22 Jun '19

4:18 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33678

Change subject: Makefile: Use -Wold-style-definition ......................................................................

Makefile: Use -Wold-style-definition

Warn if an old-style function definition is used.

Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M 3rdparty/vboot M Makefile.inc 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/33678/1

diff --git a/3rdparty/vboot b/3rdparty/vboot index dac763c..850ac8f 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit dac763c782ce05476dec02e855f349d2b6f3a910 +Subproject commit 850ac8f2ff6c5fa0dbdf9c8137bcc22a9546ace0 diff --git a/Makefile.inc b/Makefile.inc index 7ac0a82..73fd401 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -401,7 +401,7 @@

CFLAGS_common += -pipe -g -nostdinc -std=gnu11 CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes -CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs +CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wold-style-definition CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Angel Pons (Code Review)

22 Jun 22 Jun

4:30 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33678 )

Change subject: Makefile: Use -Wold-style-definition ......................................................................

Patch Set 1:

I would ask the Google people what they think of this first.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb Gerrit-Change-Number: 33678 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Sat, 22 Jun 2019 14:30:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

5 p.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33678 )

Change subject: Makefile: Use -Wold-style-definition ......................................................................

Abandoned

too much

-- To view, visit https://review.coreboot.org/c/coreboot/+/33678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb Gerrit-Change-Number: 33678 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: abandon

Martin Roth (Code Review)

7:29 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33678 )

Change subject: Makefile: Use -Wold-style-definition ......................................................................

Patch Set 1:

Did you look at fixing the problems in src/cpu/x86/smm/smm_module_handler.c?

We've got 2 definitions there that are probably pulled into every x86 platform. void __weak northbridge_smi_handler() {} void __weak southbridge_smi_handler() {}

I looked at a couple of platforms, and those were the only 2 issues I saw, despite the overwhelming number of failures.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb Gerrit-Change-Number: 33678 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Sat, 22 Jun 2019 17:29:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

8:46 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33678 )

Change subject: Makefile: Use -Wold-style-definition ......................................................................

Patch Set 1:

...

Patch Set 1:

Did you look at fixing the problems in src/cpu/x86/smm/smm_module_handler.c?

We've got 2 definitions there that are probably pulled into every x86 platform. void __weak northbridge_smi_handler() {} void __weak southbridge_smi_handler() {}

I looked at a couple of platforms, and those were the only 2 issues I saw, despite the overwhelming number of failures.

I don't think so: grep -r " __weak"

-- To view, visit https://review.coreboot.org/c/coreboot/+/33678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb Gerrit-Change-Number: 33678 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Sat, 22 Jun 2019 18:46:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

26 Jun 26 Jun

1:36 p.m.

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/33678 )

Change subject: Makefile: Use -Wold-style-definition ......................................................................

Restored

-- To view, visit https://review.coreboot.org/c/coreboot/+/33678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb Gerrit-Change-Number: 33678 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: restore

HAOUAS Elyes (Code Review)

1:36 p.m.

Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33678

to look at the new patch set (#2).

Change subject: Makefile: Use -Wold-style-definition ......................................................................

Makefile: Use -Wold-style-definition

Warn if an old-style function definition is used.

Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M Makefile.inc M src/cpu/x86/smm/smm_module_handler.c 2 files changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/33678/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb Gerrit-Change-Number: 33678 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

1:37 p.m.

HAOUAS Elyes has removed Nico Huber from this change. ( https://review.coreboot.org/c/coreboot/+/33678 )

Change subject: Makefile: Use -Wold-style-definition ......................................................................

Removed reviewer Nico Huber.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb Gerrit-Change-Number: 33678 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: deleteReviewer

HAOUAS Elyes (Code Review)

2:17 p.m.

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33678 )

Change subject: Makefile: Use -Wold-style-definition ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/33678 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0180ff7d4898cd468ff86bcf821656537e4a7edb Gerrit-Change-Number: 33678 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: abandon

1969

days inactive

1973

days old

coreboot-gerrit@coreboot.org

8 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Martin Roth (Code Review)