Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29651 )
Change subject: soc/intel/cannonlake: Program HD Audio SVID/SSID
......................................................................
Patch Set 5:
Is this just setting subsystem ids of a PCI device? These should be
set in the devicetree and no blob needed.
FWIW the reason we set subsystem IDs in Kconfig and not devicetree
is so we (google) can easily override them when building firmware
images for unreleased devices.
That's a valid case. But why jump through hoops here instead of
updating the whole of coreboot to be more flexible about subsystem
IDs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488
Gerrit-Change-Number: 29651
Gerrit-PatchSet: 5
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Jairaj Arava
jairaj.arava@intel.com
Gerrit-Reviewer: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Sathyanarayana Nujella
sathyanarayana.nujella@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sat, 01 Dec 2018 00:30:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment