Change in coreboot[master]: soc/intel/common/block/timer: Add config to enable/disable PM timer s...
Meera Ravindranath has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Added config to support PM Timer enable/disable.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/1
diff --git a/src/soc/intel/common/block/timer/Kconfig b/src/soc/intel/common/block/timer/Kconfig index a214ef0..4e5f03c 100644 --- a/src/soc/intel/common/block/timer/Kconfig +++ b/src/soc/intel/common/block/timer/Kconfig @@ -12,3 +12,9 @@ the FSP Integration guide Legacy 8254 timer clock gating UPD needs to be disabled in order to boot SeaBIOS or run OpRom, but should otherwise be enabled. + +config USE_ACPI_PM_TIMER + bool "Use ACPI PM Timer" + help + This disables the ACPI PM Timer by default. +
Meera Ravindranath has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Removed reviewer Patrick Rudolph.
Hello Aamir Bohra, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#2).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Added config to support PM Timer enable/disable.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/2
Hello Patrick Rudolph, Aamir Bohra, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#3).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Added config to support PM Timer enable/disable.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/3
Hello Patrick Rudolph, Aamir Bohra, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#4).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Added config to support PM Timer enable/disable.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/4
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/4/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/4/src/soc/intel/common/block/... PS4, Line 19: disables the ACPI PM Timer by default. Allows a provision to enable or disable ACPI PM timer?
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36034/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36034/4//COMMIT_MSG@9 PS4, Line 9: Added Add
https://review.coreboot.org/c/coreboot/+/36034/4//COMMIT_MSG@10 PS4, Line 10: Why is such an option needed?
https://review.coreboot.org/c/coreboot/+/36034/4/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/4/src/soc/intel/common/block/... PS4, Line 19: ACPI PM Timer But it says *Use ACPI PM Timer* in the description?
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 5:
whats the benefit of creating Kconfig ?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/5/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/5/src/soc/intel/common/block/... PS5, Line 16: config USE_ACPI_PM_TIMER I know this just mimics the Kconfig name above. But "use" is really confusing, coreboot will never use this timer. I think `ENABLE_ACPI_PM_TIMER` would catch it much better.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 5:
Patch Set 5:
whats the benefit of creating Kconfig ?
This is being created to further use it to support tianocore boot. Please have a look at the other two CLs https://review.coreboot.org/c/coreboot/+/36064 https://review.coreboot.org/c/coreboot/+/36067
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/5/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/5/src/soc/intel/common/block/... PS5, Line 16: config USE_ACPI_PM_TIMER
I know this just mimics the Kconfig name above. But "use" is […]
Ack
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#6).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Add config to support PM Timer enable/disable.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/6
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36034/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36034/4//COMMIT_MSG@9 PS4, Line 9: Added
Add
Done
https://review.coreboot.org/c/coreboot/+/36034/4//COMMIT_MSG@10 PS4, Line 10:
Why is such an option needed?
This Kconfig would be further used to support TianoCore boot which requires PM timer to be enabled.
https://review.coreboot.org/c/coreboot/+/36034/4/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/4/src/soc/intel/common/block/... PS4, Line 19: ACPI PM Timer
But it says *Use ACPI PM Timer* in the description?
Ack
https://review.coreboot.org/c/coreboot/+/36034/4/src/soc/intel/common/block/... PS4, Line 19: disables the ACPI PM Timer by default.
Allows a provision to enable or disable ACPI PM timer?
Ack
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#7).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Added config to support PM Timer enable/disable.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/7
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/7/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/7/src/soc/intel/common/block/... PS7, Line 19: This disables the ACPI PM Timer by default. This config enables ACPI PM timer?
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#8).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Added config to support PM Timer enable/disable.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/8
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/7/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/7/src/soc/intel/common/block/... PS7, Line 19: This disables the ACPI PM Timer by default.
This config enables ACPI PM timer?
Done
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 8: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36034/9/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/9/src/soc/intel/common/block/... PS9, Line 17: "Enable ACPI PM Timer" Does this need to be visible? What are the use cases? Please add those the CL message.
https://review.coreboot.org/c/coreboot/+/36034/9/src/soc/intel/common/block/... PS9, Line 19: config option
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#10).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Added config to support PM Timer enable/disable.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/10
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#11).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Added config to support PM Timer enable/disable to further support Tianocore boot.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/11
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36034/9/src/soc/intel/common/block/... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/9/src/soc/intel/common/block/... PS9, Line 17: "Enable ACPI PM Timer"
Does this need to be visible? What are the use cases? Please add those the CL message.
Done
https://review.coreboot.org/c/coreboot/+/36034/9/src/soc/intel/common/block/... PS9, Line 19: config
option
Done
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 12:
boards with pmtimerdisabled=0 would now need to select the ACPI_PM_TIMER Kconfig from mainboard Kconfig. Else pm timer support would be removed from those boards , with current changes.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 12:
Patch Set 12:
boards with pmtimerdisabled=0 would now need to select the ACPI_PM_TIMER Kconfig from mainboard Kconfig. Else pm timer support would be removed from those boards , with current changes.
Sorry, the comment was intended for :https://review.coreboot.org/c/coreboot/+/36064
Hello Patrick Rudolph, Subrata Banik, Aamir Bohra, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#13).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Add provision to enable/disable ACPI PM Timer via config option. The boards can now select this config option for ACPI timer support, instead of explicitly disabling it from the devicetree for the cases where ACPI timer needs to be disabled. Also, Tianocore payload boot requires ACPI PM timer to be enabled. Hence, the boards supporting Tianocore boot can now directly select this config option.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/13
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 13: Code-Review+2
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/13/src/soc/intel/common/block... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/13/src/soc/intel/common/block... PS13, Line 17: bool "Enable ACPI PM Timer" Can we put default value as n?
Hello Aaron Durbin, Patrick Rudolph, Subrata Banik, Aamir Bohra, Matt DeVillier, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#14).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Add provision to enable/disable ACPI PM Timer via config option. The boards can now select this config option for ACPI timer support, instead of explicitly disabling it from the devicetree for the cases where ACPI timer needs to be disabled. Also, Tianocore payload boot requires ACPI PM timer to be enabled. Hence, the boards supporting Tianocore boot can now directly select this config option.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/14
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/13/src/soc/intel/common/block... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/13/src/soc/intel/common/block... PS13, Line 17: bool "Enable ACPI PM Timer"
Can we put default value as n?
Done
Hello Aaron Durbin, Patrick Rudolph, Subrata Banik, Aamir Bohra, Matt DeVillier, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#15).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Add provision to enable/disable ACPI PM Timer via config option. The boards can now select this config option for ACPI timer support, instead of explicitly disabling it from the devicetree for the cases where ACPI timer needs to be disabled. Also, TianoCore payload boot requires ACPI PM timer to be enabled. Hence, the boards supporting TianoCore boot can now directly select this config option.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/15
Hello Aaron Durbin, Patrick Rudolph, Subrata Banik, Aamir Bohra, Matt DeVillier, Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36034
to look at the new patch set (#16).
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
soc/intel/common/block/timer: Add config to enable/disable PM timer support
Add provision to enable/disable ACPI PM Timer via config option. The boards can now select this config option for ACPI timer support, instead of explicitly disabling it from the devicetree for the cases where ACPI timer needs to be disabled. Also, TianoCore payload boot requires ACPI PM timer to be enabled. Hence, the boards supporting TianoCore boot can now directly select this config option.
BUG=none TEST=none
Change-Id: I42fcf23523889d47f0491fad662ca6b3587ab348 Signed-off-by: Meera Ravindranath meera.ravindranath@intel.com --- M src/soc/intel/common/block/timer/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/36034/16
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 16: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/13/src/soc/intel/common/block... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/13/src/soc/intel/common/block... PS13, Line 17: bool "Enable ACPI PM Timer"
Done
n would have been the default
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/16/src/soc/intel/common/block... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/16/src/soc/intel/common/block... PS16, Line 18: default n default y if PAYLOAD_TIANOCORE
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/16/src/soc/intel/common/block... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/16/src/soc/intel/common/block... PS16, Line 18: default n
default y if PAYLOAD_TIANOCORE
is this the only use case for which it should default to enabled? Is there any interaction with the above 8254 timer setting?
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36034/16/src/soc/intel/common/block... File src/soc/intel/common/block/timer/Kconfig:
https://review.coreboot.org/c/coreboot/+/36034/16/src/soc/intel/common/block... PS16, Line 16: ENABLE_ACPI_PM_TIMER Why is this feature in this file? It's not SoC specific as earlier Intel platforms also allow to disable the PM timer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 16: Code-Review-1
Sorry for bringing this up so late in review. But I only now understand the existing code better, at least I believe so.
It seems this whole story is just a workaround for a bug in coreboot. We don't have to enable the timer because we have the emulated timer instead. The bug is that we don't report the timer in ACPI, see CB:23510. I think all we need is to apply that to the stale copies (cannonlake/ icelake/ tigerlake/).
Aamir Bohra has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Removed Code-Review+1 by Aamir Bohra aamir.bohra@intel.com
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 16:
Patch Set 16: Code-Review-1
Sorry for bringing this up so late in review. But I only now understand the existing code better, at least I believe so.
It seems this whole story is just a workaround for a bug in coreboot. We don't have to enable the timer because we have the emulated timer instead. The bug is that we don't report the timer in ACPI, see CB:23510. I think all we need is to apply that to the stale copies (cannonlake/ icelake/ tigerlake/).
Agree, Thanks for sharing CB:23510, we can port it for cnl/icl/tgl and check for tianocore boot support.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 16:
Patch Set 16:
Patch Set 16: Code-Review-1
Sorry for bringing this up so late in review. But I only now understand the existing code better, at least I believe so.
It seems this whole story is just a workaround for a bug in coreboot. We don't have to enable the timer because we have the emulated timer instead. The bug is that we don't report the timer in ACPI, see CB:23510. I think all we need is to apply that to the stale copies (cannonlake/ icelake/ tigerlake/).
Agree, Thanks for sharing CB:23510, we can port it for cnl/icl/tgl and check for tianocore boot support.
Agreed. Thanks Nico for sharing CB:23510. Ported the changes to icl,cnl,tgl in https://review.coreboot.org/c/coreboot/+/37662. Kindly review.
Meera Ravindranath has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Abandoned
Found a better mechanism to handle PM timer. Porting https://review.coreboot.org/c/coreboot/+/23510/ to icl,cnl and tgl
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36034 )
Change subject: soc/intel/common/block/timer: Add config to enable/disable PM timer support ......................................................................
Patch Set 16:
We found another use case for exposing this timer in Kconfig: With the timer disabled, the TCO watchdog also stops and its OS driver can't do anything about it.
I can take this over, or maybe you can revive this change? Let me know what you prefer.
-
Aamir Bohra (Code Review) -
Arthur Heymans (Code Review)
-
Matt DeVillier (Code Review)
-
Maulik V Vaghela (Code Review)
-
Meera Ravindranath (Code Review)
-
Nico Huber (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Subrata Banik (Code Review)