Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28448 )
Change subject: util/lint: Update non-ascii linter for FreeBSD ......................................................................
Patch Set 1:
(3 comments)
really nice work...
https://review.coreboot.org/#/c/28448/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/28448/1//COMMIT_MSG@13 PS1, Line 13: the other linters already don't support this. do you mind indenting here ? My Ubuntu's `vim` does this per default on `gqip`.
https://review.coreboot.org/#/c/28448/1/util/lint/lint-stable-016-non-ascii File util/lint/lint-stable-016-non-ascii:
https://review.coreboot.org/#/c/28448/1/util/lint/lint-stable-016-non-ascii@... PS1, Line 37: # shellcheck disable=SC2046 Are you sure this is needed? My shellcheck didn't bark and it's all quoted after all...
https://review.coreboot.org/#/c/28448/1/util/lint/lint-stable-016-non-ascii@... PS1, Line 38: P Perl-compatible regexp is optional in `git`, is there possibly another way to match this range?
-
Alex Thiessen (Code Review)