Change in ...coreboot[master]: soc/intel/apollolake: use correct size for xlate_region_device_ro_ini...
Christian Gmeiner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31499
Change subject: soc/intel/apollolake: use correct size for xlate_region_device_ro_init(..) ......................................................................
soc/intel/apollolake: use correct size for xlate_region_device_ro_init(..)
fast_spi_get_bios_region(..) returns the size of the BIOS region as defined in the IFD. It is wrong the substract 256k from that size and use the resulting value to call xlate_region_device_ro_init(..).
The result is that the region used by the newly created region_device is 256K smaller then the one defined in IFD.
Change-Id: Ic950f28990a645556a04303f04953a7bc5e41a39 Signed-off-by: Christian Gmeiner christian.gmeiner@gmail.com --- M src/soc/intel/apollolake/mmap_boot.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/31499/1
diff --git a/src/soc/intel/apollolake/mmap_boot.c b/src/soc/intel/apollolake/mmap_boot.c index 1c3077e..6b05752 100644 --- a/src/soc/intel/apollolake/mmap_boot.c +++ b/src/soc/intel/apollolake/mmap_boot.c @@ -92,8 +92,7 @@ bios_mapped_size);
xlate_region_device_ro_init(real_dev_ptr, &shadow_dev_ptr->rdev, - start, bios_mapped_size, - CONFIG_ROM_SIZE); + start, size, CONFIG_ROM_SIZE);
car_set_var(bios_size, size); }
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31499 )
Change subject: soc/intel/apollolake: use correct size for xlate_region_device_ro_init(..) ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31499/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31499/1//COMMIT_MSG@14 PS1, Line 14: 256K smaller then the one defined in IFD. That was the original intention. Don't cover the 256KiB, because we can't use it for (memory-mapped) flash storage.
If you use the BIOS region's size, you still can't access the full BIOS region, you'll access SRAM instead in that area.
Christian Gmeiner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31499 )
Change subject: soc/intel/apollolake: use correct size for xlate_region_device_ro_init(..) ......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
Need to thing about this change some more - as you pointed out via irc it could also be my (faulty) fmd file.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31499 )
Change subject: soc/intel/apollolake: use correct size for xlate_region_device_ro_init(..) ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31499/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31499/1//COMMIT_MSG@14 PS1, Line 14: 256K smaller then the one defined in IFD.
That was the original intention. Don't cover the 256KiB, because […]
That is correct. Please see this: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/apollolake/...
Christian Gmeiner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31499 )
Change subject: soc/intel/apollolake: use correct size for xlate_region_device_ro_init(..) ......................................................................
Abandoned
I had a problem in the fmd. I was missing a BIOS_UNUSABLE@0xEBF000 0x40000 for the 256K area.
-
Christian Gmeiner (Code Review) -
Furquan Shaikh (Code Review)
-
Nico Huber (Code Review)