Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41714 )
Change subject: [WIP] mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM ......................................................................
[WIP] mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM
Change-Id: I6d6a24cb66a104c549790f039049a17ecbef208f Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/asrock/h110m/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/41714/1
diff --git a/src/mainboard/asrock/h110m/Kconfig b/src/mainboard/asrock/h110m/Kconfig index eebce57..425aff4 100644 --- a/src/mainboard/asrock/h110m/Kconfig +++ b/src/mainboard/asrock/h110m/Kconfig @@ -16,6 +16,7 @@ select SUPERIO_NUVOTON_NCT6791D_COM_A select REALTEK_8168_RESET select RT8168_SET_LED_MODE + select MAINBOARD_HAS_LPC_TPM
config IRQ_SLOT_COUNT int
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41714 )
Change subject: [WIP] mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM ......................................................................
Patch Set 2: Code-Review+1
Hello build bot (Jenkins), Maxim Polyakov, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41714
to look at the new patch set (#4).
Change subject: mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM ......................................................................
mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM
Change-Id: I6d6a24cb66a104c549790f039049a17ecbef208f Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/asrock/h110m/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/41714/4
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41714 )
Change subject: mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM ......................................................................
Patch Set 4: Code-Review+1
Unfortunately, I can’t test it now. The motherboard is in the office and I can’t get there due to the situation with the covid virus.
Can we add this without testing? I don't think that this can break something.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41714 )
Change subject: mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM ......................................................................
Patch Set 4: Code-Review+2
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41714 )
Change subject: mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41714 )
Change subject: mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM ......................................................................
mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM
Change-Id: I6d6a24cb66a104c549790f039049a17ecbef208f Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41714 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Maxim Polyakov: Looks good to me, approved
diff --git a/src/mainboard/asrock/h110m/Kconfig b/src/mainboard/asrock/h110m/Kconfig index eebce57..425aff4 100644 --- a/src/mainboard/asrock/h110m/Kconfig +++ b/src/mainboard/asrock/h110m/Kconfig @@ -16,6 +16,7 @@ select SUPERIO_NUVOTON_NCT6791D_COM_A select REALTEK_8168_RESET select RT8168_SET_LED_MODE + select MAINBOARD_HAS_LPC_TPM
config IRQ_SLOT_COUNT int
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41714 )
Change subject: mb/asrock/h110m: Select MAINBOARD_HAS_LPC_TPM ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4640 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4639 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4638 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4637
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Kyösti Mälkki (Code Review)
-
Maxim Polyakov (Code Review)
-
Patrick Georgi (Code Review)