Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63969 )
Change subject: soc/intel/alderlake: provide a list of D-states to enter LPM ......................................................................
Patch Set 18:
(4 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/3ca46d5d_004ef9bb PS14, Line 1485: __weak uint8_t soc_lpi_get_constraints(void) { return 0; }
nit: move after line 1483?
Ack
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/98aafe65_c2d19eb7 PS17, Line 1485: __weak uint8_t soc_lpi_get_constraints(void) { return 0; }
Another option is the weak implementation does the single device/dummy entry creation and that get […]
In patchset 18
File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/c6127cb7_9446f5de PS13, Line 440: if (dev && dev->enabled) { : switch (dev->path.type) { : case DEVICE_PATH_PCI: : return (min_pci_d_states[dev->path.pci.devfn] != UNDEF); : : case DEVICE_PATH_APIC: : return true; : : default: : return false; : } : } : return false;
I believe we would still want to add a check in here that the entry we're interested in actually exi […]
Ack
File src/soc/intel/common/block/acpi/pep.c:
https://review.coreboot.org/c/coreboot/+/63969/comment/0edde040_91acacb4 PS17, Line 74: {
nit: brace goes to previous line
Ack. No longer relevant with latest patch.