Attention is currently required from: Julius Werner, Yu-Ping Wu. Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63115 )
Change subject: libpayload: Add CONFIG_LP_ELOG and its dependency ......................................................................
Patch Set 9:
(1 comment)
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63115/comment/fd729b0e_a8d39433 PS9, Line 51: classes-$(CONFIG_LP_ELOG) += elog
libc
As Yu-ping mentioned, we've tried to add it into libc but elog was actually not really related to core c library.
Adding libutil might be another good choice, I would think some other things e.g. fmap.c code also consider as a 'util', WDYT?
Kconfig
Though it is still a small file only, I am not sure if we should prevent including it for the non-ChromeOS platforms since I am not familiar with them. If you think it is okay to unconditionally adding it now (and no plan to enlarge it yet), I will change it.
-
Hsuan-ting Chen (Code Review)