Change in ...coreboot[master]: security/vboot: Add measured boot mode

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29547 )

Change subject: security/vboot: Add measured boot mode
......................................................................

Patch Set 43:

(2 comments)

https://review.coreboot.org/#/c/29547/43/src/security/vboot/vboot_crtm.c 
File src/security/vboot/vboot_crtm.c:

https://review.coreboot.org/#/c/29547/43/src/security/vboot/vboot_crtm.c@56 
PS43, Line 56:
> move tpm_measure_region() here to increase readability

There are different arguments for tpm_measure_region() in both cases. Do you want to have these arguments stored in a variable? Or how do you prefer the handling of this different arguments?

https://review.coreboot.org/#/c/29547/43/src/security/vboot/vboot_crtm.c@80 
PS43, Line 80: 	if (IS_ENABLED(CONFIG_VBOOT_SEPARATE_VERSTAGE)) {
> else if ?

Why? The upper code deals with romstage while this one deals with verstage. We need to be able to have both paths active in one run. Or do I oversee something here?