Change in coreboot[master]: soc/intel/cannonlake: Allow setting PCIe subsystem IDs after FSP Sili...

[Angel Pons (Code Review)]

Attention is currently required from:  Felix Singer, Tim Crawford, Jeremy Soller.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49104 )

Change subject: soc/intel/cannonlake: Allow setting PCIe subsystem IDs after FSP SiliconInit
......................................................................

Patch Set 4:

(3 comments)

File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/49104/comment/4fa21c7f_8025b522 
PS2, Line 550: 1
> If set to 0 (default), then FspSiliconInit will write the default 8086:7270 value.

Ack

File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/49104/comment/4b333560_92f306f6 
PS4, Line 528: 	/* Disable setting subsystem ID, which causes it to lock */
I couldn't resolve `it` when parsing this sentence. How about:

/* Prevent FSP from programming write-only subsystem IDs */

https://review.coreboot.org/c/coreboot/+/49104/comment/ee500075_7b3893fc 
PS4, Line 548: 	const struct svid_ssid_init_entry ssid_table[] = {0};
Do not allocate this variable on the stack. After this function returns, any pointers to local variables become dangling references because the underlying storage has been released, so any accesses through said pointers would trigger undefined behavior.

Solution: Prefix this with `static`.