Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35106 )
Change subject: google/leon: Add DRIVERS_I2C_RTD2132 ......................................................................
google/leon: Add DRIVERS_I2C_RTD2132
This is LVDS bridge, I assume this was lost while upstreaming or converting boards to variants.
Change-Id: I816a6b4035c4e935150cc77089c4224eee719c10 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/google/slippy/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/35106/1
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index 242876d..35fced0 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -16,6 +16,7 @@ select INTEL_INT15 select MAINBOARD_HAS_LIBGFXINIT select INTEL_GMA_HAVE_VBT + select DRIVERS_I2C_RTD2132 if BOARD_GOOGLE_LEON
if BOARD_GOOGLE_BASEBOARD_SLIPPY
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35106 )
Change subject: google/leon: Add DRIVERS_I2C_RTD2132 ......................................................................
Patch Set 1:
looks like there's some devicetree params that go with it: https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/3ac2d658...
I think when leon was upstreamed, the other firmware-leon branch was used, which lacks this commit. I've never heard any complains from leon users, but not opposed to adding this as long as both parts are added
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35106 )
Change subject: google/leon: Add DRIVERS_I2C_RTD2132 ......................................................................
Patch Set 1:
Well the params in devicetree are already merged, thst's how I noticed this.
You probably don't hear or see 209 MHz EMI... :)
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35106 )
Change subject: google/leon: Add DRIVERS_I2C_RTD2132 ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35106 )
Change subject: google/leon: Add DRIVERS_I2C_RTD2132 ......................................................................
google/leon: Add DRIVERS_I2C_RTD2132
This is LVDS bridge, I assume this was lost while upstreaming or converting boards to variants.
Change-Id: I816a6b4035c4e935150cc77089c4224eee719c10 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35106 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/slippy/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/google/slippy/Kconfig b/src/mainboard/google/slippy/Kconfig index 242876d..35fced0 100644 --- a/src/mainboard/google/slippy/Kconfig +++ b/src/mainboard/google/slippy/Kconfig @@ -16,6 +16,7 @@ select INTEL_INT15 select MAINBOARD_HAS_LIBGFXINIT select INTEL_GMA_HAVE_VBT + select DRIVERS_I2C_RTD2132 if BOARD_GOOGLE_LEON
if BOARD_GOOGLE_BASEBOARD_SLIPPY
-
Kyösti Mälkki (Code Review) -
Matt DeVillier (Code Review)