Attention is currently required from: Paul Menzel, Curtis Chen, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59736 )
Change subject: soc/intel/alderlake: Add ADL-P 682 (28W) VR config ......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59736/comment/12617926_a3ccd4f3 PS2, Line 7: 682 nit: `6+8+2`
https://review.coreboot.org/c/coreboot/+/59736/comment/1712321f_f5467648 PS2, Line 9: 682 nit: `6+8+2`
https://review.coreboot.org/c/coreboot/+/59736/comment/bf09e9f1_b817b481 PS2, Line 10: 682 nit: `6+8+2`
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/59736/comment/27e99f5c_2a138b7a PS2, Line 53: 682 nit: `6+8+2` also space after `(`
-
Tim Wawrzynczak (Code Review)