Attention is currently required from: Jonathan Zhang, Stefan Reinauer, Arthur Heymans, Patrick Rudolph.
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52160 )
Change subject: soc/intel/xeon_sp: Set MSR locks
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/52160/comment/afddf2f1_82de4c10
PS1, Line 39: PARALLEL_MP_AP_WORK
remove from tiogapass Kconfig.
Ack
File src/soc/intel/xeon_sp/cpx/chip.c:
https://review.coreboot.org/c/coreboot/+/52160/comment/3d8ecb59_56bd5e60
PS1, Line 146: set_msr_locks
This has to happen so late or can it happen during the CPU init?
I think that this could happen in each_cpu_init, but I have been getting feedback to set the locks in finalize functions. *s, shrug* I guess someone might change turbo just prior to ACPI table setup. AES lock could be set anytime.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacf495f0880d42b378cb0d2c37940d50a511c430
Gerrit-Change-Number: 52160
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 07 Apr 2021 18:29:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment