Attention is currently required from: Furquan Shaikh, Maulik V Vaghela, Tim Wawrzynczak.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55945 )
Change subject: drivers/intel/usb4/retimer: Update code to assign correct port number
......................................................................
Patch Set 2:
(2 comments)
File src/drivers/intel/usb4/retimer/retimer.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123128):
https://review.coreboot.org/c/coreboot/+/55945/comment/26c28ac7_68b8fe4c
PS2, Line 359: "%s: No DFP%1d power GPIO for %s \n", __func__,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123128):
https://review.coreboot.org/c/coreboot/+/55945/comment/11baaf21_41eefdc3
PS2, Line 359: "%s: No DFP%1d power GPIO for %s \n", __func__,
unnecessary whitespace before a quoted newline
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib11637ae39046e0afdacd33bc34e8a59e6f2bfb1
Gerrit-Change-Number: 55945
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Abhijeet Rao
abhijeet.rao@intel.corp-partner.google.com
Gerrit-CC: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 01 Jul 2021 10:28:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment