build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63560 )
Change subject: [VERY WIP]tests/cpu/x86/smm: Add unit tests ......................................................................
Patch Set 23: Verified-1
(10 comments)
File tests/cpu/x86/smm/smm_loader.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150325): https://review.coreboot.org/c/coreboot/+/63560/comment/a21d91f1_5089c391 PS23, Line 54: #define setup_rmodule(mod , c) \ space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150325): https://review.coreboot.org/c/coreboot/+/63560/comment/7e8df1c2_39b057fa PS23, Line 54: #define setup_rmodule(mod , c) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150325): https://review.coreboot.org/c/coreboot/+/63560/comment/2839806b_a42668f9 PS23, Line 59: hdr->payload_begin_offset = (uintptr_t)(stub_module->program) - (uintptr_t)stub_module; \ line length of 97 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150325): https://review.coreboot.org/c/coreboot/+/63560/comment/d2251b4f_ed5fec63 PS23, Line 66: hdr->parameters_begin = (uintptr_t)&stub_module->params - (uintptr_t)stub_module->program; \ line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150325): https://review.coreboot.org/c/coreboot/+/63560/comment/9238ccad_f192738a PS23, Line 80: /* hdr->payload_begin_offset = (uintptr_t)(stub_module->program) - (uintptr_t)stub_module; */ line length of 101 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150325): https://review.coreboot.org/c/coreboot/+/63560/comment/21120a4e_2ee8973a PS23, Line 87: /* hdr->parameters_begin = (uintptr_t)&stub_module->params - (uintptr_t)stub_module->program ; */ line length of 105 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150325): https://review.coreboot.org/c/coreboot/+/63560/comment/42349a41_3d8ad240 PS23, Line 93: /* stub_module->program[i] = stub_string[i % sizeof(stub_string)]; */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150325): https://review.coreboot.org/c/coreboot/+/63560/comment/09f35fa4_91690a97 PS23, Line 106: hdr->payload_begin_offset = (uintptr_t)(handler_module->program) - (uintptr_t)handler_module; line length of 101 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150325): https://review.coreboot.org/c/coreboot/+/63560/comment/92763f78_92998dbc PS23, Line 107: hdr->payload_end_offset = (uintptr_t)(handler_module->program) - (uintptr_t)handler_module + sizeof(handler_module->program); line length of 133 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150325): https://review.coreboot.org/c/coreboot/+/63560/comment/b5118a1d_06809f94 PS23, Line 113: hdr->parameters_begin = (uintptr_t)&handler_module->params - (uintptr_t)handler_module->program; line length of 104 exceeds 96 columns