Change in coreboot[master]: soc/intel/tigerlake: Make PCH_DEV_UART3 macro definition proper

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39673 )

Change subject: soc/intel/tigerlake: Make PCH_DEV_UART3 macro definition proper
......................................................................

soc/intel/tigerlake: Make PCH_DEV_UART3 macro definition proper

This patch makes PCH_DEV_UART3 macro referring to _PCH_DEV()
rather calling _PCH_DEVFN().

Change-Id: I7bc060c3c5f1e0a0fed194704b4940db73f46985
Signed-off-by: Subrata Banik 
---
M src/soc/intel/tigerlake/include/soc/pci_devs.h
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/39673/1

diff --git a/src/soc/intel/tigerlake/include/soc/pci_devs.h b/src/soc/intel/tigerlake/include/soc/pci_devs.h
index 8b740cf..f7ecc3f 100644
--- a/src/soc/intel/tigerlake/include/soc/pci_devs.h
+++ b/src/soc/intel/tigerlake/include/soc/pci_devs.h
@@ -67,7 +67,7 @@

#define PCH_DEV_SLOT_SIO1	0x11
 #define  PCH_DEVFN_UART3	_PCH_DEVFN(SIO1, 0)
-#define  PCH_DEV_UART3          _PCH_DEVFN(SIO1, 0)
+#define  PCH_DEV_UART3          _PCH_DEV(SIO1, 0)

#define PCH_DEV_SLOT_ISH	0x12
 #define  PCH_DEVFN_ISH		_PCH_DEVFN(ISH, 0)

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39673 )

Change subject: soc/intel/tigerlake: Make PCH_DEV_UART3 macro definition proper
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39673 )

Change subject: soc/intel/tigerlake: Make PCH_DEV_UART3 macro definition proper
......................................................................

Patch Set 1: Code-Review+2

Oops 😄

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39673 )

Change subject: soc/intel/tigerlake: Make PCH_DEV_UART3 macro definition proper
......................................................................

soc/intel/tigerlake: Make PCH_DEV_UART3 macro definition proper

This patch makes PCH_DEV_UART3 macro referring to _PCH_DEV()
rather calling _PCH_DEVFN().

Change-Id: I7bc060c3c5f1e0a0fed194704b4940db73f46985
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39673
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Angel Pons 
---
M src/soc/intel/tigerlake/include/soc/pci_devs.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/tigerlake/include/soc/pci_devs.h b/src/soc/intel/tigerlake/include/soc/pci_devs.h
index 8b740cf..f7ecc3f 100644
--- a/src/soc/intel/tigerlake/include/soc/pci_devs.h
+++ b/src/soc/intel/tigerlake/include/soc/pci_devs.h
@@ -67,7 +67,7 @@

#define PCH_DEV_SLOT_SIO1	0x11
 #define  PCH_DEVFN_UART3	_PCH_DEVFN(SIO1, 0)
-#define  PCH_DEV_UART3          _PCH_DEVFN(SIO1, 0)
+#define  PCH_DEV_UART3          _PCH_DEV(SIO1, 0)

#define PCH_DEV_SLOT_ISH	0x12
 #define  PCH_DEVFN_ISH		_PCH_DEVFN(ISH, 0)