Attention is currently required from: Wenbin Mei.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51966 )
Change subject: soc/mediatek: add new driver 'msdc' for eMMC
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/common/include/soc/msdc.h:
https://review.coreboot.org/c/coreboot/+/51966/comment/d5243daf_26f51874
PS5, Line 62: /*--------------------------------------------------------------------------*/
: /* Register Mask */
: /*--------------------------------------------------------------------------*/
will you consider redefining all the masks, using DEFINE_BITFIELDS ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51966
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54a7749ed167c00cd631a76af7c67c654c7bc725
Gerrit-Change-Number: 51966
Gerrit-PatchSet: 5
Gerrit-Owner: Wenbin Mei
wenbin.mei@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Wenbin Mei
wenbin.mei@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 06 Apr 2021 01:30:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment