Attention is currently required from: Raul Rangel, Marshall Dawson. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56817 )
Change subject: soc/amd/common/block/acpi/gpio: add warning for remote GPIO usage ......................................................................
Patch Set 3: Verified+1
(2 comments)
File src/soc/amd/common/block/acpi/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127567): https://review.coreboot.org/c/coreboot/+/56817/comment/76d0eb1a_821013e2 PS3, Line 14: if (SOC_GPIO_TOTAL_PINS >= AMD_GPIO_FIRST_REMOTE_GPIO_NUMBER && Comparisons should place the constant on the right side of the test
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127567): https://review.coreboot.org/c/coreboot/+/56817/comment/1936ae89_5a546d9a PS3, Line 33: if (SOC_GPIO_TOTAL_PINS >= AMD_GPIO_FIRST_REMOTE_GPIO_NUMBER && Comparisons should place the constant on the right side of the test