Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37357 )
Change subject: src/drivers: Fix various issues discovered by checkpatch ......................................................................
src/drivers: Fix various issues discovered by checkpatch
Change-Id: I46e318333e68b999b2889f51fa2fbf140a27a54e Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/drivers/spi/tpm/tis.c M src/drivers/usb/ehci_debug.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/37357/1
diff --git a/src/drivers/spi/tpm/tis.c b/src/drivers/spi/tpm/tis.c index 7d42b7c..6230751 100644 --- a/src/drivers/spi/tpm/tis.c +++ b/src/drivers/spi/tpm/tis.c @@ -9,7 +9,7 @@
#include "tpm.h"
-static unsigned tpm_is_open; +static unsigned int tpm_is_open;
static const struct { uint16_t vid; diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index e77cd85..d6b468c 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -59,7 +59,7 @@ static void dbgp_print_data(struct ehci_dbg_port *ehci_debug);
static struct ehci_debug_info glob_dbg_info; -static struct ehci_debug_info * glob_dbg_info_p; +static struct ehci_debug_info *glob_dbg_info_p;
static inline struct ehci_debug_info *dbgp_ehci_info(void) {
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37357 )
Change subject: src/drivers: Fix various issues discovered by checkpatch ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37357 )
Change subject: src/drivers: Fix various issues discovered by checkpatch ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37357 )
Change subject: src/drivers: Fix various issues discovered by checkpatch ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37357/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37357/1//COMMIT_MSG@7 PS1, Line 7: various two
Hello Kyösti Mälkki, HAOUAS Elyes, Arthur Heymans, Paul Menzel, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37357
to look at the new patch set (#2).
Change subject: src/drivers: Fix two issues discovered by checkpatch ......................................................................
src/drivers: Fix two issues discovered by checkpatch
Change-Id: I46e318333e68b999b2889f51fa2fbf140a27a54e Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/drivers/spi/tpm/tis.c M src/drivers/usb/ehci_debug.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/37357/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37357 )
Change subject: src/drivers: Fix two issues discovered by checkpatch ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37357/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37357/1//COMMIT_MSG@7 PS1, Line 7: various
two
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37357 )
Change subject: src/drivers: Fix two issues discovered by checkpatch ......................................................................
Patch Set 2: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37357 )
Change subject: src/drivers: Fix two issues discovered by checkpatch ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37357 )
Change subject: src/drivers: Fix two issues discovered by checkpatch ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37357 )
Change subject: src/drivers: Fix two issues discovered by checkpatch ......................................................................
src/drivers: Fix two issues discovered by checkpatch
Change-Id: I46e318333e68b999b2889f51fa2fbf140a27a54e Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37357 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/spi/tpm/tis.c M src/drivers/usb/ehci_debug.c 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/drivers/spi/tpm/tis.c b/src/drivers/spi/tpm/tis.c index 7d42b7c..6230751 100644 --- a/src/drivers/spi/tpm/tis.c +++ b/src/drivers/spi/tpm/tis.c @@ -9,7 +9,7 @@
#include "tpm.h"
-static unsigned tpm_is_open; +static unsigned int tpm_is_open;
static const struct { uint16_t vid; diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index e77cd85..d6b468c 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -59,7 +59,7 @@ static void dbgp_print_data(struct ehci_dbg_port *ehci_debug);
static struct ehci_debug_info glob_dbg_info; -static struct ehci_debug_info * glob_dbg_info_p; +static struct ehci_debug_info *glob_dbg_info_p;
static inline struct ehci_debug_info *dbgp_ehci_info(void) {
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)