Attention is currently required from: Sean Rhodes. Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60165 )
Change subject: ec/starlabs/merlin: Apply EC settings when suspending ......................................................................
Patch Set 6:
(2 comments)
File src/ec/starlabs/merlin/acpi/suspend.asl:
https://review.coreboot.org/c/coreboot/+/60165/comment/57f04fc8_8cd8f10b PS6, Line 9: /* Store current EC settings */ Suggest amending the comment to /* Store current EC settings in CMOS */ to remove any ambiguity about where they are going.
https://review.coreboot.org/c/coreboot/+/60165/comment/9777d3b7_55e74544 PS6, Line 10: _SB.PCI0.LPCB.TPLS = _SB.PCI0.LPCB.EC.TPLA It would make the code more obvious if the names of the ECRAM and corresponding CMOS entries were given the same names.