Change in coreboot[master]: mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs
David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47351 )
Change subject: mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs ......................................................................
mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs
This change adds memory parts used by variant voema to mem_parts_used.txt and generates DRAM IDs allocated to these parts.
Added memory 1. H9HCNNNCRMBLPR-NEE 2. H9HCNNNFBMBLPR-NEE 3. MT53D1G64D4NW-046 WT:A
BUG=b:172751925 TEST=emerge-volteer coreboot chromeos-bootimage
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Ic832155448fb07152b906aa04ca49d384ec47b34 --- M src/mainboard/google/volteer/variants/voema/memory/Makefile.inc M src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt M src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt 3 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/47351/1
diff --git a/src/mainboard/google/volteer/variants/voema/memory/Makefile.inc b/src/mainboard/google/volteer/variants/voema/memory/Makefile.inc index 3c8ea48..7b69aa4 100644 --- a/src/mainboard/google/volteer/variants/voema/memory/Makefile.inc +++ b/src/mainboard/google/volteer/variants/voema/memory/Makefile.inc @@ -2,5 +2,6 @@ ## This is an auto-generated file. Do not edit!!
SPD_SOURCES = -SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M64D4NW-046 WT:E -SPD_SOURCES += lp4x-spd-3.hex # ID = 1(0b0001) Parts = MT53E1G64D8NW-046 WT:E +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M64D4NW-046 WT:E, H9HCNNNCRMBLPR-NEE +SPD_SOURCES += lp4x-spd-3.hex # ID = 1(0b0001) Parts = MT53E1G64D8NW-046 WT:E, H9HCNNNFBMBLPR-NEE +SPD_SOURCES += lp4x-spd-4.hex # ID = 2(0b0010) Parts = MT53D1G64D4NW-046 WT:A diff --git a/src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt index 02e7443..840f71a 100644 --- a/src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt +++ b/src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt @@ -1,3 +1,6 @@ DRAM Part Name ID to assign MT53E512M64D4NW-046 WT:E 0 (0000) MT53E1G64D8NW-046 WT:E 1 (0001) +H9HCNNNCRMBLPR-NEE 0 (0000) +H9HCNNNFBMBLPR-NEE 1 (0001) +MT53D1G64D4NW-046 WT:A 2 (0010) diff --git a/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt b/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt index b74da4a..c74fe43 100644 --- a/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt +++ b/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt @@ -1,2 +1,5 @@ MT53E512M64D4NW-046 WT:E MT53E1G64D8NW-046 WT:E +H9HCNNNCRMBLPR-NEE +H9HCNNNFBMBLPR-NEE +MT53D1G64D4NW-046 WT:A
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47351
to look at the new patch set (#2).
Change subject: mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs ......................................................................
mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs
This change adds memory parts used by variant voema to mem_parts_used.txt and generates DRAM IDs allocated to these parts.
Added memory 1. H9HCNNNCRMBLPR-NEE 2. H9HCNNNFBMBLPR-NEE 3. MT53D1G64D4NW-046 WT:A
BUG=b:172751925,b:172781673,b:172782100,b:172781562 TEST=emerge-volteer coreboot chromeos-bootimage
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Ic832155448fb07152b906aa04ca49d384ec47b34 --- M src/mainboard/google/volteer/variants/voema/memory/Makefile.inc M src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt M src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt 3 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/47351/2
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47351 )
Change subject: mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47351/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt:
PS2: what happened here? you should only have 3 entries and not repeat IDs.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47351 )
Change subject: mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47351/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt:
PS2:
what happened here? you should only have 3 entries and not repeat IDs.
This file contains list of all memory parts used and the ID to assign to that part. This is how the spd_tool generates the file.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47351 )
Change subject: mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 2: Code-Review+1
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47351 )
Change subject: mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47351/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt:
PS2:
This file contains list of all memory parts used and the ID to assign to that part. […]
Ack
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47351 )
Change subject: mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47351 )
Change subject: mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs ......................................................................
mb/google/volteer/var/voema: Add memory parts and generate DRAM IDs
This change adds memory parts used by variant voema to mem_parts_used.txt and generates DRAM IDs allocated to these parts.
Added memory 1. H9HCNNNCRMBLPR-NEE 2. H9HCNNNFBMBLPR-NEE 3. MT53D1G64D4NW-046 WT:A
BUG=b:172751925,b:172781673,b:172782100,b:172781562 TEST=emerge-volteer coreboot chromeos-bootimage
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: Ic832155448fb07152b906aa04ca49d384ec47b34 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47351 Reviewed-by: Caveh Jalali caveh@chromium.org Reviewed-by: Nick Vaccaro nvaccaro@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/voema/memory/Makefile.inc M src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt M src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt 3 files changed, 9 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nick Vaccaro: Looks good to me, approved Caveh Jalali: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/voema/memory/Makefile.inc b/src/mainboard/google/volteer/variants/voema/memory/Makefile.inc index 3c8ea48..7b69aa4 100644 --- a/src/mainboard/google/volteer/variants/voema/memory/Makefile.inc +++ b/src/mainboard/google/volteer/variants/voema/memory/Makefile.inc @@ -2,5 +2,6 @@ ## This is an auto-generated file. Do not edit!!
SPD_SOURCES = -SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M64D4NW-046 WT:E -SPD_SOURCES += lp4x-spd-3.hex # ID = 1(0b0001) Parts = MT53E1G64D8NW-046 WT:E +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M64D4NW-046 WT:E, H9HCNNNCRMBLPR-NEE +SPD_SOURCES += lp4x-spd-3.hex # ID = 1(0b0001) Parts = MT53E1G64D8NW-046 WT:E, H9HCNNNFBMBLPR-NEE +SPD_SOURCES += lp4x-spd-4.hex # ID = 2(0b0010) Parts = MT53D1G64D4NW-046 WT:A diff --git a/src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt index 02e7443..840f71a 100644 --- a/src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt +++ b/src/mainboard/google/volteer/variants/voema/memory/dram_id.generated.txt @@ -1,3 +1,6 @@ DRAM Part Name ID to assign MT53E512M64D4NW-046 WT:E 0 (0000) MT53E1G64D8NW-046 WT:E 1 (0001) +H9HCNNNCRMBLPR-NEE 0 (0000) +H9HCNNNFBMBLPR-NEE 1 (0001) +MT53D1G64D4NW-046 WT:A 2 (0010) diff --git a/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt b/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt index b74da4a..c74fe43 100644 --- a/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt +++ b/src/mainboard/google/volteer/variants/voema/memory/mem_parts_used.txt @@ -1,2 +1,5 @@ MT53E512M64D4NW-046 WT:E MT53E1G64D8NW-046 WT:E +H9HCNNNCRMBLPR-NEE +H9HCNNNFBMBLPR-NEE +MT53D1G64D4NW-046 WT:A
-
Caveh Jalali (Code Review) -
David Wu (Code Review)
-
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Patrick Georgi (Code Review)