Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74758 )
Change subject: soc/amd/mendocino: Add FSP parameter for eDP power sequence adjustment
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/mendocino/fsp_m_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174922):
https://review.coreboot.org/c/coreboot/+/74758/comment/c54fcba8_192974b1
PS1, Line 174: mcfg->pwr_down_bloff_to_varybloff = config-> pwr_down_bloff_to_varybloff;
spaces prohibited around that '->' (ctx:VxW)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74758
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdf50db12d982b45edca205e8f4612deb702453d
Gerrit-Change-Number: 74758
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 25 Apr 2023 14:31:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment