Change in ...coreboot[master]: mainboard/{iei,intel}: remove stdlib.h when unused

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33906

Change subject: mainboard/{iei,intel}: remove stdlib.h when unused
......................................................................

mainboard/{iei,intel}: remove stdlib.h when unused

Change-Id: Ib6151ac245870a198afb71909a36a0840480d567
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/iei/kino-780am2-fam10/get_bus_conf.c
M src/mainboard/intel/kblrvp/mainboard.c
2 files changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/33906/1

diff --git a/src/mainboard/iei/kino-780am2-fam10/get_bus_conf.c b/src/mainboard/iei/kino-780am2-fam10/get_bus_conf.c
index 237ef2a..89ac836 100644
--- a/src/mainboard/iei/kino-780am2-fam10/get_bus_conf.c
+++ b/src/mainboard/iei/kino-780am2-fam10/get_bus_conf.c
@@ -15,7 +15,6 @@

#include <device/pci.h>
 #include <stdint.h>
-#include <stdlib.h>
 #include <cpu/amd/multicore.h>
 #include <cpu/amd/amdfam10_sysconf.h>

diff --git a/src/mainboard/intel/kblrvp/mainboard.c b/src/mainboard/intel/kblrvp/mainboard.c
index 78c7ae4..a21b1cf 100644
--- a/src/mainboard/intel/kblrvp/mainboard.c
+++ b/src/mainboard/intel/kblrvp/mainboard.c
@@ -18,12 +18,12 @@
 #include <arch/acpi.h>
 #include <device/device.h>
 #include <gpio.h>
-#include <stdlib.h>
 #include <soc/nhlt.h>
 #include <vendorcode/google/chromeos/chromeos.h>
-#include "ec.h"
 #include <variant/gpio.h>

+#include "ec.h"
+
 static void mainboard_init(struct device *dev)
 {
    if (CONFIG(EC_GOOGLE_CHROMEEC))

Change in coreboot[master]: mb/intel/kblrvp: Remove unused include <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33906

to look at the new patch set (#2).

Change subject: mb/intel/kblrvp: Remove unused include <stdlib.h>
......................................................................

mb/intel/kblrvp: Remove unused include <stdlib.h>

Change-Id: Ib6151ac245870a198afb71909a36a0840480d567
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/intel/kblrvp/mainboard.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/33906/2

Change in coreboot[master]: mb/intel/kblrvp: Remove unused include <stdlib.h>

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33906 )

Change subject: mb/intel/kblrvp: Remove unused include <stdlib.h>
......................................................................

Abandoned

see 32023

Change in coreboot[master]: mb/intel/kblrvp: Remove unused include <stdlib.h>

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/33906 )

Change subject: mb/intel/kblrvp: Remove unused include <stdlib.h>
......................................................................

Restored

Change in coreboot[master]: mb/{hp,intel}: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33906

to look at the new patch set (#3).

Change subject: mb/{hp,intel}: Remove unused <stdlib.h>
......................................................................

mb/{hp,intel}: Remove unused <stdlib.h>

Change-Id: Ib6151ac245870a198afb71909a36a0840480d567
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/hp/abm/BiosCallOuts.c
M src/mainboard/hp/abm/buildOpts.c
M src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c
M src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
M src/mainboard/intel/kblrvp/mainboard.c
M src/mainboard/intel/kunimitsu/mainboard.c
M src/mainboard/intel/strago/gpio.c
7 files changed, 0 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/33906/3

Change in coreboot[master]: mb/{hp,intel}: Remove unused <stdlib.h>

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33906

to look at the new patch set (#7).

Change subject: mb/{hp,intel}: Remove unused <stdlib.h>
......................................................................

mb/{hp,intel}: Remove unused <stdlib.h>

Change-Id: Ib6151ac245870a198afb71909a36a0840480d567
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c
M src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
M src/mainboard/intel/kblrvp/mainboard.c
M src/mainboard/intel/kunimitsu/mainboard.c
M src/mainboard/intel/strago/gpio.c
5 files changed, 0 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/33906/7

Change in coreboot[master]: mb/{hp,intel}: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33906 )

Change subject: mb/{hp,intel}: Remove unused <stdlib.h>
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: mb/{hp,intel}: Remove unused <stdlib.h>

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33906 )

Change subject: mb/{hp,intel}: Remove unused <stdlib.h>
......................................................................

mb/{hp,intel}: Remove unused <stdlib.h>

Change-Id: Ib6151ac245870a198afb71909a36a0840480d567
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33906
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
---
M src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c
M src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
M src/mainboard/intel/kblrvp/mainboard.c
M src/mainboard/intel/kunimitsu/mainboard.c
M src/mainboard/intel/strago/gpio.c
5 files changed, 0 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved

diff --git a/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c b/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c
index 2b1ac04..f36e11e 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c
+++ b/src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c
@@ -19,7 +19,6 @@

#include <southbridge/amd/agesa/hudson/imc.h>
 #include <vendorcode/amd/agesa/f15tn/Proc/Fch/FchPlatform.h>
-#include <stdlib.h>

const BIOS_CALLOUT_STRUCT BiosCallouts[] =
 {
diff --git a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
index c6d62ed..e56d513 100644
--- a/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
+++ b/src/mainboard/hp/pavilion_m6_1035dx/buildOpts.c
@@ -27,7 +27,6 @@

#include "mainboard.h"

-#include <stdlib.h>

#include <vendorcode/amd/agesa/f15tn/AGESA.h>

diff --git a/src/mainboard/intel/kblrvp/mainboard.c b/src/mainboard/intel/kblrvp/mainboard.c
index 78c7ae4..d2e8719 100644
--- a/src/mainboard/intel/kblrvp/mainboard.c
+++ b/src/mainboard/intel/kblrvp/mainboard.c
@@ -18,7 +18,6 @@
 #include <arch/acpi.h>
 #include <device/device.h>
 #include <gpio.h>
-#include <stdlib.h>
 #include <soc/nhlt.h>
 #include <vendorcode/google/chromeos/chromeos.h>
 #include "ec.h"
diff --git a/src/mainboard/intel/kunimitsu/mainboard.c b/src/mainboard/intel/kunimitsu/mainboard.c
index 4c93051..be2f262 100644
--- a/src/mainboard/intel/kunimitsu/mainboard.c
+++ b/src/mainboard/intel/kunimitsu/mainboard.c
@@ -19,7 +19,6 @@
 #include <console/console.h>
 #include <device/device.h>
 #include <gpio.h>
-#include <stdlib.h>
 #include <soc/nhlt.h>
 #include <vendorcode/google/chromeos/chromeos.h>
 #include "ec.h"
diff --git a/src/mainboard/intel/strago/gpio.c b/src/mainboard/intel/strago/gpio.c
index ed9ae4b..9acc8a0 100644
--- a/src/mainboard/intel/strago/gpio.c
+++ b/src/mainboard/intel/strago/gpio.c
@@ -16,7 +16,6 @@

#include "irqroute.h"
 #include <soc/gpio.h>
-#include <stdlib.h>
 #include <boardid.h>
 #include "onboard.h"
 #include "gpio.h"