Change in coreboot[master]: mb/google/zork: Fix SPD typo in trembyle makefile

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Rob Barnes (Code Review)

31 Aug 2020 31 Aug '20

9:26 p.m.

Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44946 )

Change subject: mb/google/zork: Fix SPD typo in trembyle makefile ......................................................................

mb/google/zork: Fix SPD typo in trembyle makefile

Relative path to spd directory was wrong.

BUG=b:167175547 TEST=Boot Trembyle SKU 2

Change-Id: I63ae4f39ba69d2d80c25ac7383b6eb953901f56d Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/trembyle/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/44946/1

diff --git a/src/mainboard/google/zork/variants/trembyle/Makefile.inc b/src/mainboard/google/zork/variants/trembyle/Makefile.inc index e22847e..57e7136 100644 --- a/src/mainboard/google/zork/variants/trembyle/Makefile.inc +++ b/src/mainboard/google/zork/variants/trembyle/Makefile.inc @@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-or-later

-subdirs-y += ../spd +subdirs-y += ./spd

ramstage-y += gpio.c

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Furquan Shaikh (Code Review)

31 Aug 31 Aug

9:28 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44946 )

Change subject: mb/google/zork: Fix SPD typo in trembyle makefile ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63ae4f39ba69d2d80c25ac7383b6eb953901f56d Gerrit-Change-Number: 44946 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Mon, 31 Aug 2020 19:28:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Matt Papageorge (Code Review)

9:29 p.m.

Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44946 )

Change subject: mb/google/zork: Fix SPD typo in trembyle makefile ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/44946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63ae4f39ba69d2d80c25ac7383b6eb953901f56d Gerrit-Change-Number: 44946 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Mon, 31 Aug 2020 19:29:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:29 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44946 )

Change subject: mb/google/zork: Fix SPD typo in trembyle makefile ......................................................................

Patch Set 1:

We should also update templates for trembyle and dalboz in follow-up CLs: https://review.coreboot.org/cgit/coreboot.git/tree/util/mainboard/google/tre...

https://review.coreboot.org/cgit/coreboot.git/tree/util/mainboard/google/dal...

-- To view, visit https://review.coreboot.org/c/coreboot/+/44946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63ae4f39ba69d2d80c25ac7383b6eb953901f56d Gerrit-Change-Number: 44946 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Mon, 31 Aug 2020 19:29:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aaron Durbin (Code Review)

10:34 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44946 )

Change subject: mb/google/zork: Fix SPD typo in trembyle makefile ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63ae4f39ba69d2d80c25ac7383b6eb953901f56d Gerrit-Change-Number: 44946 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 31 Aug 2020 20:34:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11:20 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44946 )

Change subject: mb/google/zork: Fix SPD typo in trembyle makefile ......................................................................

Patch Set 1:

Landing this early to fix regression on trembyle.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63ae4f39ba69d2d80c25ac7383b6eb953901f56d Gerrit-Change-Number: 44946 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 31 Aug 2020 21:20:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11:20 p.m.

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44946 )

Change subject: mb/google/zork: Fix SPD typo in trembyle makefile ......................................................................

mb/google/zork: Fix SPD typo in trembyle makefile

Relative path to spd directory was wrong.

BUG=b:167175547 TEST=Boot Trembyle SKU 2

Change-Id: I63ae4f39ba69d2d80c25ac7383b6eb953901f56d Signed-off-by: Rob Barnes robbarnes@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44946 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Matt Papageorge matthewpapa07@gmail.com Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/trembyle/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Matt Papageorge: Looks good to me, but someone else must approve

-subdirs-y += ../spd +subdirs-y += ./spd

ramstage-y += gpio.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/44946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I63ae4f39ba69d2d80c25ac7383b6eb953901f56d Gerrit-Change-Number: 44946 Gerrit-PatchSet: 2 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1537

days inactive

1537

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

Aaron Durbin (Code Review)
Furquan Shaikh (Code Review)
Matt Papageorge (Code Review)
Rob Barnes (Code Review)