[L] Change in coreboot[main]: soc/intel/xeon_sp: Unshare Xeon-SP chip common codes

[Arthur Heymans (Code Review)]

Attention is currently required from: Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Martin L Roth, Paul Menzel, Shuo Liu, TangYiwei, Tim Chu.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81312?usp=email )

Change subject: soc/intel/xeon_sp: Unshare Xeon-SP chip common codes
......................................................................

Patch Set 11: Code-Review+2

(2 comments)

Patchset:

PS11: 
Looks good. Let me know what you think of my suggestion.

File src/soc/intel/xeon_sp/Makefile.mk:

https://review.coreboot.org/c/coreboot/+/81312/comment/ee893be5_c3696cb5 :
PS11, Line 18: ramstage-$(CONFIG_SOC_INTEL_SKYLAKE_SP) += chip_gen1.c
             : ramstage-$(CONFIG_SOC_INTEL_COOPERLAKE_SP) += chip_gen1.c
             : ramstage-$(CONFIG_SOC_INTEL_SAPPHIRERAPIDS_SP) += chip_gen1.c
Any thoughts on including it in the makefile from the respective dirs?

so ramstage-y += ../chip_gen1.c in spr-sp/Makefile.mk ?

I don't feel strongly but I think it would be a bit cleaner?