Attention is currently required from: Lance Zhao, Francois Toguo Fotso, Martin Roth, Paul Menzel, Nikunj Dadhania, Tim Wawrzynczak, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49799 )
Change subject: acpi: Add support for reporting CrashLog in BERT table
......................................................................
Patch Set 9: Code-Review+2
(3 comments)
Patchset:
PS9:
Thanks Francois!
File src/arch/x86/acpi_bert_storage.c:
https://review.coreboot.org/c/coreboot/+/49799/comment/cf4d30df_028b7cb5
PS7, Line 229: 2
Is this defined somewhere already? If not, would you mind adding a `#define` for this?
Ack
https://review.coreboot.org/c/coreboot/+/49799/comment/1ee42f5c_f6b30fe1
PS7, Line 229: recort
record
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00e390d735d61beac2e89a726e39119d9b06b3df
Gerrit-Change-Number: 49799
Gerrit-PatchSet: 9
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikunj Dadhania
nikunj.dadhania@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nikunj Dadhania
nikunj.dadhania@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 02 Feb 2021 16:50:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment