Attention is currently required from: Nico Huber.
Hello Nico Huber,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/libgfxinit/+/82137?usp=email
to review the following change.
Change subject: gma display_probing: Make new TGL ports available ......................................................................
gma display_probing: Make new TGL ports available
Change-Id: I9d96673f931be0086536044694ecd127ba2a823d Signed-off-by: Nico Huber nico.huber@secunet.com --- M common/hw-gfx-gma-display_probing.adb M common/hw-gfx-gma-display_probing.ads 2 files changed, 26 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/37/82137/1
diff --git a/common/hw-gfx-gma-display_probing.adb b/common/hw-gfx-gma-display_probing.adb index 67f8ddf..fa2a4f7 100644 --- a/common/hw-gfx-gma-display_probing.adb +++ b/common/hw-gfx-gma-display_probing.adb @@ -75,12 +75,26 @@
declare DP_Port : constant GMA.DP_Port := - (case Port is - when eDP => DP_A, - when DP1 => DP_B, - when DP2 => DP_C, - when DP3 => DP_D, - when others => GMA.DP_Port'First); + (if Config.Has_Type_C_Ports then + (case Port is + when eDP => DP_A, -- FIXME: should be configurable which is used for eDP + when DP1 => DP_A, + when DP2 => DP_B, + when DP3 => DP_C, + when USBC1_DP => DP_D, + when USBC2_DP => DP_E, + when USBC3_DP => DP_F, + when USBC4_DP => DP_G, + when USBC5_DP => DP_H, + when USBC6_DP => DP_I, + when others => GMA.DP_Port'First) + else + (case Port is + when eDP => DP_A, + when DP1 => DP_B, + when DP2 => DP_C, + when DP3 => DP_D, + when others => GMA.DP_Port'First)); begin DP_Aux_Ch.I2C_Read (Port => DP_Port, diff --git a/common/hw-gfx-gma-display_probing.ads b/common/hw-gfx-gma-display_probing.ads index 5dcdbd4..7479fdd 100644 --- a/common/hw-gfx-gma-display_probing.ads +++ b/common/hw-gfx-gma-display_probing.ads @@ -17,10 +17,14 @@ package HW.GFX.GMA.Display_Probing is
- type Port_List_Range is range 0 .. 8; + type Port_List_Range is range 0 .. 20; type Port_List is array (Port_List_Range) of Port_Type; All_Ports : constant Port_List := - (DP1, DP2, DP3, HDMI1, HDMI2, HDMI3, Analog, LVDS, eDP); + (DP1, DP2, DP3, + HDMI1, HDMI2, HDMI3, + USBC1_DP, USBC2_DP, USBC3_DP, USBC4_DP, USBC5_DP, USBC6_DP, + USBC1_HDMI, USBC2_HDMI, USBC3_HDMI, USBC4_HDMI, USBC5_HDMI, USBC6_HDMI, + Analog, LVDS, eDP);
procedure Read_EDID (Raw_EDID : out EDID.Raw_EDID_Data;