Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38299 )
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters ......................................................................
mb/google/hatch/variants/helios: Modify DPTF parameters
Modify DTRT CPU Throttle Effect on TSR0 change to TSR3.
BUG=b:131272830 BRANCH=none TEST=emerge-hatch coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I5b4645d7552e795a33c1b86d95c4061da71c65bd --- M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38299/1
diff --git a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl index a359284..f40d10a 100644 --- a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl @@ -99,8 +99,8 @@ })
Name (DTRT, Package () { - /* CPU Throttle Effect on TSR0 */ - Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 }, + /* CPU Throttle Effect on TSR3 */ + Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR3, 100, 60, 0, 0, 0, 0 },
/* Charger Throttle Effect on TSR0 */ Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 },
Hello Philip Chen, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38299
to look at the new patch set (#2).
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters ......................................................................
mb/google/hatch/variants/helios: Modify DPTF parameters
Modify DTRT CPU Throttle Effect on TSR0 change to TSR3.
BUG=b:131272830 BRANCH=firmware-hatch-12672.B TEST=emerge-hatch coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I5b4645d7552e795a33c1b86d95c4061da71c65bd --- M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/38299/2
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38299 )
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters ......................................................................
Patch Set 2: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38299 )
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters ......................................................................
Patch Set 2: Code-Review+2
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38299 )
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38299 )
Change subject: mb/google/hatch/variants/helios: Modify DPTF parameters ......................................................................
mb/google/hatch/variants/helios: Modify DPTF parameters
Modify DTRT CPU Throttle Effect on TSR0 change to TSR3.
BUG=b:131272830 BRANCH=firmware-hatch-12672.B TEST=emerge-hatch coreboot chromeos-bootimage
Signed-off-by: Kane Chen kane_chen@pegatron.corp-partner.google.com Change-Id: I5b4645d7552e795a33c1b86d95c4061da71c65bd Reviewed-on: https://review.coreboot.org/c/coreboot/+/38299 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Shelley Chen shchen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Kane Chen: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl index a359284..f40d10a 100644 --- a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl +++ b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl @@ -99,8 +99,8 @@ })
Name (DTRT, Package () { - /* CPU Throttle Effect on TSR0 */ - Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 }, + /* CPU Throttle Effect on TSR3 */ + Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR3, 100, 60, 0, 0, 0, 0 },
/* Charger Throttle Effect on TSR0 */ Package () { _SB.DPTF.TCHG, _SB.DPTF.TSR0, 100, 60, 0, 0, 0, 0 },
-
Kane Chen (Code Review) -
Nico Huber (Code Review)
-
Shelley Chen (Code Review)
-
Tim Wawrzynczak (Code Review)