Change in coreboot[master]: src/security: Fix typos

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

src/security: Fix typos

Change-Id: I238fce2d48cf62003a701f972a87974415419538
Signed-off-by: Elyes HAOUAS 
---
M src/security/tpm/tis.h
M src/security/vboot/misc.h
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/38198/1

diff --git a/src/security/tpm/tis.h b/src/security/tpm/tis.h
index c410838..db7d92b 100644
--- a/src/security/tpm/tis.h
+++ b/src/security/tpm/tis.h
@@ -66,7 +66,7 @@
 /*
  * tis_close()
  *
- * terminate the currect session with the TPM by releasing the locked
+ * terminate the current session with the TPM by releasing the locked
  * locality. Returns 0 on success of -1 on failure (in case lock
  * removal did not succeed).
  */
diff --git a/src/security/vboot/misc.h b/src/security/vboot/misc.h
index 0b2c8e5..2d5b084 100644
--- a/src/security/vboot/misc.h
+++ b/src/security/vboot/misc.h
@@ -89,7 +89,7 @@

/* If we are in the stage that runs verification, or in the stage that
       both loads the verstage and is returned to from it afterwards, we
-	   need to check a global to see if verfication has run. */
+	   need to check a global to see if verification has run. */
    if (verification_should_run() ||
        (verstage_should_load() && CONFIG(VBOOT_RETURN_FROM_VERSTAGE)))
    	return vboot_executed;

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

Patch Set 3: Code-Review+1

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

Patch Set 4: Code-Review-2

No. Did you contact the author of the change, and ask whether he/she meant to put 'current' or 'correct'?
-2 score, since you are trying to read minds.

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

Patch Set 4: Code-Review+2

[Idwer Vollering (Code Review)]

Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

Patch Set 4:

(I don't see this 'currect' in https://review.coreboot.org/c/coreboot/+/22104 )

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

Patch Set 4:
> Patch Set 4: Code-Review-2
>
> No. Did you contact the author of the change, and ask whether he/she meant to put 'current' or 'correct'?
> -2 score, since you are trying to read minds.

What is the meaning of "correct session" here please ?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

Patch Set 4:
> Patch Set 4: Code-Review-2
>
> No. Did you contact the author of the change, and ask whether he/she meant to put 'current' or 'correct'?
> -2 score, since you are trying to read minds.

Huh, let's give 'correct' a try:

/*
  * tis_close()
  *
  * terminate the correct session with the TPM by releasing the locked
  * locality. Returns 0 on success of -1 on failure (in case lock
  * removal did not succeed).
  */
 int tis_close(void);

Sooo... How would this function know which is *the* correct session? Does it read minds as well?

Also, if you check CB:6519 (git blame says this is when the typo was first introduced), you can see that the code works with a global state, so it doesn't know any sessions other than the current. In any case, we can ask Stefan Reinauer about it.

Aside, a minor thing like this one doesn't need to be hammered with a -2. Now that we have the `All-Comments-Resolved` score, any unresolved comments prevent submitting a change, so they can be used for `sanity checks`. On a change with many greens (+1 and +2), it's a good idea to also give a -1, as the red color sticks out noticeably (if not colorblind).

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

Patch Set 4: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

Patch Set 4:

Idwer, I don't think the comment makes any sense with "correct". Also,
this is TPM code, the typo has been copied some times around the world
before it landed here. So unless you want to find the original author
yourself, please remove your -2.

[Idwer Vollering (Code Review)]

Idwer Vollering has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

Removed Code-Review-2 by Idwer Vollering

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38198 )

Change subject: src/security: Fix typos
......................................................................

src/security: Fix typos

Change-Id: I238fce2d48cf62003a701f972a87974415419538
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38198
Tested-by: build bot (Jenkins) 
Reviewed-by: Aaron Durbin 
Reviewed-by: Nico Huber 
Reviewed-by: Paul Menzel 
Reviewed-by: Angel Pons 
---
M src/security/tpm/tis.h
M src/security/vboot/misc.h
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Aaron Durbin: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/security/tpm/tis.h b/src/security/tpm/tis.h
index c410838..db7d92b 100644
--- a/src/security/tpm/tis.h
+++ b/src/security/tpm/tis.h
@@ -66,7 +66,7 @@
 /*
  * tis_close()
  *
- * terminate the currect session with the TPM by releasing the locked
+ * terminate the current session with the TPM by releasing the locked
  * locality. Returns 0 on success of -1 on failure (in case lock
  * removal did not succeed).
  */
diff --git a/src/security/vboot/misc.h b/src/security/vboot/misc.h
index 0b2c8e5..2d5b084 100644
--- a/src/security/vboot/misc.h
+++ b/src/security/vboot/misc.h
@@ -89,7 +89,7 @@

/* If we are in the stage that runs verification, or in the stage that
       both loads the verstage and is returned to from it afterwards, we
-	   need to check a global to see if verfication has run. */
+	   need to check a global to see if verification has run. */
    if (verification_should_run() ||
        (verstage_should_load() && CONFIG(VBOOT_RETURN_FROM_VERSTAGE)))
    	return vboot_executed;