Patch Set 4: Code-Review-2

No. Did you contact the author of the change, and ask whether he/she meant to put 'current' or 'correct'?
-2 score, since you are trying to read minds.

Huh, let's give 'correct' a try:

 /*
  * tis_close()
  *
  * terminate the correct session with the TPM by releasing the locked
  * locality. Returns 0 on success of -1 on failure (in case lock
  * removal did not succeed).
  */
 int tis_close(void);

Sooo... How would this function know which is *the* correct session? Does it read minds as well?

Also, if you check CB:6519 (git blame says this is when the typo was first introduced), you can see that the code works with a global state, so it doesn't know any sessions other than the current. In any case, we can ask Stefan Reinauer about it.

Aside, a minor thing like this one doesn't need to be hammered with a -2. Now that we have the `All-Comments-Resolved` score, any unresolved comments prevent submitting a change, so they can be used for `sanity checks`. On a change with many greens (+1 and +2), it's a good idea to also give a -1, as the red color sticks out noticeably (if not colorblind).

View Change

To view, visit change 38198. To unsubscribe, or for help writing mail filters, visit settings.