Attention is currently required from: Bao Zheng, Angel Pons, Felix Held.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59581 )
Change subject: amdfwtool: remove duplicates
......................................................................
Patch Set 1:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/59581/comment/b488191e_2c56bafe
PS1, Line 205: if (cb_config->use_secureos) {
: fw_type = AMD_FW_PSP_TRUSTLETS;
: subprog = 0;
: } else {
: fw_type = AMD_FW_SKIP;
: }
Just to be sure, is this correct? The removed duplicate condition always used `AMD_FW_PSP_TRUSTLETS` […]
To be honest there's no documentation so I don't know, need review from AMD. Practically use_secureos is enabled on stoney/picasso/cezanne/sabrina(afaik all platforms with PSP) so it won't make any difference.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b86e24ba1c2769985e2864528e4dfcbf3cccc4b
Gerrit-Change-Number: 59581
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Bao Zheng
zheng.bao@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Bao Zheng
zheng.bao@amd.corp-partner.google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 05 Apr 2022 07:22:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment