Change in coreboot[master]: mb/google/dedede/var/madoo: Enable keyboard backlight feature

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ian Feng (Code Review)

14 Sep 2020 14 Sep '20

12:42 a.m.

Ian Feng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45330 )

Change subject: mb/google/dedede/var/madoo: Enable keyboard backlight feature ......................................................................

mb/google/dedede/var/madoo: Enable keyboard backlight feature

This enables the keyboard backlight feature in ACPI for madoo.

BUG=b:167943993 TEST=Verified 'kbd_backlight' shows up in the '/sys/class/leds'.

Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Change-Id: I11531699cb650b96becae5c1bec9f89c48b6bea0 --- M src/mainboard/google/dedede/variants/madoo/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/45330/1

diff --git a/src/mainboard/google/dedede/variants/madoo/include/variant/ec.h b/src/mainboard/google/dedede/variants/madoo/include/variant/ec.h index 08870e0..d6c3859 100644 --- a/src/mainboard/google/dedede/variants/madoo/include/variant/ec.h +++ b/src/mainboard/google/dedede/variants/madoo/include/variant/ec.h @@ -5,4 +5,7 @@

#include <baseboard/ec.h>

+/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Ian Feng (Code Review)

14 Sep 14 Sep

12:45 a.m.

Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45330 )

Change subject: mb/google/dedede/var/madoo: Enable keyboard backlight feature ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/45330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11531699cb650b96becae5c1bec9f89c48b6bea0 Gerrit-Change-Number: 45330 Gerrit-PatchSet: 1 Gerrit-Owner: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 14 Sep 2020 07:45:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ian Feng (Code Review)

12:45 a.m.

Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45330 )

Change subject: mb/google/dedede/var/madoo: Enable keyboard backlight feature ......................................................................

Patch Set 1: -Code-Review

-- To view, visit https://review.coreboot.org/c/coreboot/+/45330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11531699cb650b96becae5c1bec9f89c48b6bea0 Gerrit-Change-Number: 45330 Gerrit-PatchSet: 1 Gerrit-Owner: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 14 Sep 2020 07:45:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

EricR Lai (Code Review)

12:46 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45330 )

Change subject: mb/google/dedede/var/madoo: Enable keyboard backlight feature ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11531699cb650b96becae5c1bec9f89c48b6bea0 Gerrit-Change-Number: 45330 Gerrit-PatchSet: 1 Gerrit-Owner: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-Comment-Date: Mon, 14 Sep 2020 07:46:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ian Feng (Code Review)

6:20 p.m.

Ian Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45330 )

Change subject: mb/google/dedede/var/madoo: Enable keyboard backlight feature ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/45330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11531699cb650b96becae5c1bec9f89c48b6bea0 Gerrit-Change-Number: 45330 Gerrit-PatchSet: 1 Gerrit-Owner: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 15 Sep 2020 01:20:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ian Feng (Code Review)

6:22 p.m.

Hello build bot (Jenkins), Henry Sun, EricR Lai, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45330

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/madoo: Enable keyboard backlight feature ......................................................................

mb/google/dedede/var/madoo: Enable keyboard backlight feature

This enables the keyboard backlight feature in ACPI for madoo.

BUG=b:167943993 TEST=Verified 'kbd_backlight' shows up in the '/sys/class/leds '.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/45330/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/45330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11531699cb650b96becae5c1bec9f89c48b6bea0 Gerrit-Change-Number: 45330 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

16 Sep 16 Sep

12:15 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45330 )

Change subject: mb/google/dedede/var/madoo: Enable keyboard backlight feature ......................................................................

mb/google/dedede/var/madoo: Enable keyboard backlight feature

This enables the keyboard backlight feature in ACPI for madoo.

BUG=b:167943993 TEST=Verified 'kbd_backlight' shows up in the '/sys/class/leds '.

Signed-off-by: Ian Feng ian_feng@compal.corp-partner.google.com Change-Id: I11531699cb650b96becae5c1bec9f89c48b6bea0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45330 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/dedede/variants/madoo/include/variant/ec.h 1 file changed, 3 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved Ian Feng: Looks good to me, but someone else must approve

#include <baseboard/ec.h>

+/* Enable EC backed Keyboard Backlight in ACPI */ +#define EC_ENABLE_KEYBOARD_BACKLIGHT + #endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/45330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11531699cb650b96becae5c1bec9f89c48b6bea0 Gerrit-Change-Number: 45330 Gerrit-PatchSet: 4 Gerrit-Owner: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

9elements QA (Code Review)

1:24 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45330 )

Change subject: mb/google/dedede/var/madoo: Enable keyboard backlight feature ......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19533 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19532 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19531 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19530 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19529 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19537 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19536 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19535 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19534

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/45330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11531699cb650b96becae5c1bec9f89c48b6bea0 Gerrit-Change-Number: 45330 Gerrit-PatchSet: 4 Gerrit-Owner: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Henry Sun henrysun@google.com Gerrit-Reviewer: Ian Feng ian_feng@compal.corp-partner.google.com Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 16 Sep 2020 08:24:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1524

days inactive

1526

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
EricR Lai (Code Review)
Ian Feng (Code Review)
Patrick Georgi (Code Review)