Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29970 )
Change subject: qcs405: Add RPM support ......................................................................
Patch Set 29:
(2 comments)
https://review.coreboot.org/#/c/29970/29/src/soc/qualcomm/qcs405/include/soc... File src/soc/qualcomm/qcs405/include/soc/memlayout.ld:
https://review.coreboot.org/#/c/29970/29/src/soc/qualcomm/qcs405/include/soc... PS29, Line 35: 76K This considerably reduces the size of the region compared to the previous patch set (from 0x2c000, which is 128K+48K). is that intentional?
https://review.coreboot.org/#/c/29970/29/src/soc/qualcomm/qcs405/rpm_load_re... File src/soc/qualcomm/qcs405/rpm_load_reset.c:
https://review.coreboot.org/#/c/29970/29/src/soc/qualcomm/qcs405/rpm_load_re... PS29, Line 42: BIOS_DEBUG BIOS_SPEW? (or remove completely)