Change in coreboot[master]: mb/purism/librem_skl: drop EC chip driver

[Matt DeVillier (Code Review)]

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem_skl: drop EC chip driver
......................................................................

mb/purism/librem_skl: drop EC chip driver

CB:35086 exposed that the devicetree listed an EC chip for which there
is no actual driver; the EC is entirely ACPI code (.asl) included by
the board's ec.asl. Remove the unnecessary EC chip driver.

Test: build/boot Librem 13v4, verify battery info etc still correct.

Signed-off-by: Matt DeVillier 
Change-Id: I5cb0b51881ab8f14e9ec693485f673f4284b5f14
---
M src/mainboard/purism/librem_skl/devicetree.cb
1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/41788/1

diff --git a/src/mainboard/purism/librem_skl/devicetree.cb b/src/mainboard/purism/librem_skl/devicetree.cb
index a439e02..d44d2ad 100644
--- a/src/mainboard/purism/librem_skl/devicetree.cb
+++ b/src/mainboard/purism/librem_skl/devicetree.cb
@@ -208,9 +208,6 @@
    	device pci 1d.2 off end # PCI Express Port 11
    	device pci 1d.3 off end # PCI Express Port 12
    	device pci 1f.0 on
-			chip ec/purism/librem
-				device pnp 0c09.0 on end
-			end
    		chip drivers/pc80/tpm
    			device pnp 0c31.0 on end
    		end

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem_skl: drop EC chip driver
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41788/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41788/1//COMMIT_MSG@7 
PS1, Line 7: mb/purism/librem_skl: drop EC chip driver
Drop ec/purism device ?

Change in coreboot[master]: mb/purism/librem_skl: drop EC chip device

[Matt DeVillier (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41788

to look at the new patch set (#2).

Change subject: mb/purism/librem_skl: drop EC chip device
......................................................................

mb/purism/librem_skl: drop EC chip device

CB:35086 exposed that the devicetree listed an EC chip for which there
is no actual driver; the EC is entirely ACPI code (.asl) included by
the board's ec.asl. Remove the unnecessary EC chip driver.

Test: build/boot Librem 13v4, verify battery info etc still correct.

Signed-off-by: Matt DeVillier 
Change-Id: I5cb0b51881ab8f14e9ec693485f673f4284b5f14
---
M src/mainboard/purism/librem_skl/devicetree.cb
1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/41788/2

Change in coreboot[master]: mb/purism/librem_skl: drop EC chip device

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem_skl: drop EC chip device
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41788/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41788/1//COMMIT_MSG@7 
PS1, Line 7: mb/purism/librem_skl: drop EC chip driver
> Drop ec/purism device ?

Done

Change in coreboot[master]: mb/purism/librem_skl: drop EC chip device

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem_skl: drop EC chip device
......................................................................

Patch Set 3:

Fails with CB:35086

https://qa.coreboot.org/job/coreboot-gerrit/128255/

Test Result (2 failures / +2)

board.PURISM_LIBREM13_V1
    board.PURISM_LIBREM15_V2

Change in coreboot[master]: mb/purism/librem_skl: drop EC chip device

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem_skl: drop EC chip device
......................................................................

Patch Set 3:
> Patch Set 3:
>
> Fails with CB:35086
>
> https://qa.coreboot.org/job/coreboot-gerrit/128255/
>
> Test Result (2 failures / +2)
> board.PURISM_LIBREM13_V1
> board.PURISM_LIBREM15_V2

well I didn't touch that board (librem_bdw) yet ;-)

Change in coreboot[master]: mb/purism/librem_skl: drop EC chip device

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem_skl: drop EC chip device
......................................................................

Patch Set 3: Code-Review+1

Why not change both librem_bdw and librem_skl?

Change in coreboot[master]: mb/purism/librem_skl: drop EC chip device

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem_skl: drop EC chip device
......................................................................

Patch Set 3:
> Patch Set 3: Code-Review+1
>
> Why not change both librem_bdw and librem_skl?

yeah I'll squash both into this patch

Change in coreboot[master]: mb/purism/librem*: drop EC chip device

[Matt DeVillier (Code Review)]

Hello build bot (Jenkins), Angel Pons, Kyösti Mälkki,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41788

to look at the new patch set (#4).

Change subject: mb/purism/librem*: drop EC chip device
......................................................................

mb/purism/librem*: drop EC chip device

CB:35086 exposed that the devicetree listed an EC chip for which there
is no actual driver; the EC is entirely ACPI code (.asl) included by
the board's ec.asl. Remove the unnecessary EC chip driver from both
boards, as well as the unnecessary Kconfig selection for librem_bdw.

Test: build/boot Librem 13v1, 13v4, verify battery info etc still correct.

Signed-off-by: Matt DeVillier 
Change-Id: I5cb0b51881ab8f14e9ec693485f673f4284b5f14
---
M src/mainboard/purism/librem_bdw/Kconfig
M src/mainboard/purism/librem_bdw/devicetree.cb
M src/mainboard/purism/librem_skl/devicetree.cb
3 files changed, 1 insertion(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/41788/4

Change in coreboot[master]: mb/purism/librem*: drop EC chip device

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem*: drop EC chip device
......................................................................

Patch Set 4:
> Patch Set 3: Code-Review+1
>
> Why not change both librem_bdw and librem_skl?

done

Change in coreboot[master]: mb/purism/librem*: drop EC chip device

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem*: drop EC chip device
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: mb/purism/librem*: drop EC chip device

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem*: drop EC chip device
......................................................................

mb/purism/librem*: drop EC chip device

CB:35086 exposed that the devicetree listed an EC chip for which there
is no actual driver; the EC is entirely ACPI code (.asl) included by
the board's ec.asl. Remove the unnecessary EC chip driver from both
boards, as well as the unnecessary Kconfig selection for librem_bdw.

Test: build/boot Librem 13v1, 13v4, verify battery info etc still correct.

Signed-off-by: Matt DeVillier 
Change-Id: I5cb0b51881ab8f14e9ec693485f673f4284b5f14
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41788
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/mainboard/purism/librem_bdw/Kconfig
M src/mainboard/purism/librem_bdw/devicetree.cb
M src/mainboard/purism/librem_skl/devicetree.cb
3 files changed, 1 insertion(+), 9 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig
index dcfe78e..202a35d 100644
--- a/src/mainboard/purism/librem_bdw/Kconfig
+++ b/src/mainboard/purism/librem_bdw/Kconfig
@@ -2,7 +2,6 @@
    def_bool n
    select SYSTEM_TYPE_LAPTOP
    select BOARD_ROMSIZE_KB_8192
-	select EC_PURISM_LIBREM
    select HAVE_ACPI_RESUME
    select HAVE_ACPI_TABLES
    select INTEL_GMA_HAVE_VBT
diff --git a/src/mainboard/purism/librem_bdw/devicetree.cb b/src/mainboard/purism/librem_bdw/devicetree.cb
index 13b9e5e..0d44cd7 100644
--- a/src/mainboard/purism/librem_bdw/devicetree.cb
+++ b/src/mainboard/purism/librem_bdw/devicetree.cb
@@ -52,11 +52,7 @@
    	device pci 1c.5 on  end # PCIe Port #6 - M.2 NVMe
    	device pci 1d.0 off end # USB2 EHCI
    	device pci 1e.0 off end # PCI bridge
-		device pci 1f.0 on
-			chip ec/purism/librem
-				device pnp 0c09.0 on end
-			end
-		end # LPC bridge
+		device pci 1f.0 on  end # LPC bridge
    	device pci 1f.2 on  end # SATA Controller
    	device pci 1f.3 on  end # SMBus
    	device pci 1f.6 off end # Thermal
diff --git a/src/mainboard/purism/librem_skl/devicetree.cb b/src/mainboard/purism/librem_skl/devicetree.cb
index a439e02..d44d2ad 100644
--- a/src/mainboard/purism/librem_skl/devicetree.cb
+++ b/src/mainboard/purism/librem_skl/devicetree.cb
@@ -208,9 +208,6 @@
    	device pci 1d.2 off end # PCI Express Port 11
    	device pci 1d.3 off end # PCI Express Port 12
    	device pci 1f.0 on
-			chip ec/purism/librem
-				device pnp 0c09.0 on end
-			end
    		chip drivers/pc80/tpm
    			device pnp 0c31.0 on end
    		end

Change in coreboot[master]: mb/purism/librem*: drop EC chip device

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41788 )

Change subject: mb/purism/librem*: drop EC chip device
......................................................................

Patch Set 6:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4636
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4635
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4634
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4633

Please note: This test is under development and might not be accurate at all!