Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36592 )
Change subject: mb/supermicro/x11-lga1151-series: use new console delay Kconfig option
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36592/7/src/mainboard/supermicro/x1...
File src/mainboard/supermicro/x11-lga1151-series/bootblock.c:
https://review.coreboot.org/c/coreboot/+/36592/7/src/mainboard/supermicro/x1...
PS7, Line 35: if (CONFIG(CONSOLE_SERIAL))
IMO not really needed anymore since CONSOLE_SERIAL is guarded by against in Kconfig. It seems common in mb code to not guard against setting the resource. I don't really mind however since it's done in ramstage anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36592
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8bf4ef7ad9beea7b3dc22e1567623a423597eff9
Gerrit-Change-Number: 36592
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 03 Nov 2019 17:27:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment