HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41291 )
Change subject: mb/google/fizz: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/google/fizz: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: Ic04a0710f0b5cb7efd6162b21ff136fff6bcaa53 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/fizz/bootblock.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/fizz/mainboard.c 3 files changed, 2 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/41291/1
diff --git a/src/mainboard/google/fizz/bootblock.c b/src/mainboard/google/fizz/bootblock.c index efab999..e1f253f 100644 --- a/src/mainboard/google/fizz/bootblock.c +++ b/src/mainboard/google/fizz/bootblock.c @@ -2,7 +2,7 @@
#include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h>
#include <variant/gpio.h>
diff --git a/src/mainboard/google/fizz/chromeos.c b/src/mainboard/google/fizz/chromeos.c index a74c2f7..5357dcc 100644 --- a/src/mainboard/google/fizz/chromeos.c +++ b/src/mainboard/google/fizz/chromeos.c @@ -1,9 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <boot/coreboot_tables.h> -#include <gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h>
#include <variant/gpio.h> diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index ecfaf58..af7a78f 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -11,7 +11,6 @@ #include <gpio.h> #include <variant/gpio.h> #include <smbios.h> -#include <soc/gpio.h> #include <soc/pci_devs.h> #include <soc/nhlt.h> #include <stdio.h>
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41291 )
Change subject: mb/google/fizz: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324