Attention is currently required from: Tim Wawrzynczak, Karthik Ramasubramanian. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50442 )
Change subject: drivers/i2c/hid: Enforce level triggered IRQ mode ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/hid/hid.c:
https://review.coreboot.org/c/coreboot/+/50442/comment/56cb36ba_33163802 PS2, Line 79: dev->enabled = 0; Rather than setting device to disabled, would it make sense to print the warning and update the irq mode to use LEVEL triggered?
We can add a runtime assert, but generally, I think it is not a graceful way of handling a component that is not really critical for boot.
Also, there are two irq configs -- irq and irq_gpio. Probably need to check which is actually being used by the board first?
-
Furquan Shaikh (Code Review)