Change in coreboot[master]: trogdor: Add board variant checks in Kconfig

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in coreboot[master]: tests:...

Ravi kumar (Code Review)

23 Jun 2020 23 Jun '20

8:14 a.m.

Ravi kumar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42730 )

Change subject: trogdor: Add board variant checks in Kconfig ......................................................................

trogdor: Add board variant checks in Kconfig

Diffentiate Lazor and trogdor build configuration

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I3ad413ea6e658e939796bebdff8c1e0dd76417cc --- M src/mainboard/google/trogdor/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/42730/1

diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index dfd98f0..9f0e037 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -5,7 +5,8 @@ if BOARD_GOOGLE_TROGDOR_COMMON

config TROGDOR_REV0 - def_bool y + def_bool y if BOARD_GOOGLE_TROGDOR + def_bool n if BOARD_GOOGLE_LAZOR

config BOARD_SPECIFIC_OPTIONS def_bool y

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Julius Werner (Code Review)

23 Jun 23 Jun

8:50 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42730 )

Change subject: trogdor: Add board variant checks in Kconfig ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42730/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/Kconfig:

https://review.coreboot.org/c/coreboot/+/42730/1/src/mainboard/google/trogdo... PS1, Line 8: def_bool y if BOARD_GOOGLE_TROGDOR Please change the whole thing to

bool default y if BOARD_GOOGLE_TROGDOR default n

so it will get the right default for future boards too. (In general I want to eventually default this to n for Trogdor too, but we can wait with that until you guys have mostly moved off of rev0.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ad413ea6e658e939796bebdff8c1e0dd76417cc Gerrit-Change-Number: 42730 Gerrit-PatchSet: 1 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Manideep Kurumella mkurumel@qualcomm.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Tue, 23 Jun 2020 23:50:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ravi kumar (Code Review)

30 Jun 30 Jun

4:08 a.m.

Hello build bot (Jenkins), Manideep Kurumella, mturney mturney, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42730

to look at the new patch set (#3).

Change subject: trogdor: Add board variant checks in Kconfig ......................................................................

trogdor: Add board variant checks in Kconfig

Diffentiate Lazor and trogdor build configuration

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I3ad413ea6e658e939796bebdff8c1e0dd76417cc --- M src/mainboard/google/trogdor/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/42730/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/42730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ad413ea6e658e939796bebdff8c1e0dd76417cc Gerrit-Change-Number: 42730 Gerrit-PatchSet: 3 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Manideep Kurumella mkurumel@qualcomm.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: newpatchset

Julius Werner (Code Review)

6 Jul 6 Jul

8:53 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42730 )

Change subject: trogdor: Add board variant checks in Kconfig ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ad413ea6e658e939796bebdff8c1e0dd76417cc Gerrit-Change-Number: 42730 Gerrit-PatchSet: 4 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Manideep Kurumella mkurumel@qualcomm.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Mon, 06 Jul 2020 23:53:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Julius Werner (Code Review)

8:53 p.m.

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42730 )

Change subject: trogdor: Add board variant checks in Kconfig ......................................................................

Patch Set 4:

(1 comment)

Please remember to mark comments as resolved when you resolve them.

https://review.coreboot.org/c/coreboot/+/42730/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/Kconfig:

https://review.coreboot.org/c/coreboot/+/42730/1/src/mainboard/google/trogdo... PS1, Line 8: def_bool y if BOARD_GOOGLE_TROGDOR

...

Please change the whole thing to […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ad413ea6e658e939796bebdff8c1e0dd76417cc Gerrit-Change-Number: 42730 Gerrit-PatchSet: 4 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Manideep Kurumella mkurumel@qualcomm.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Comment-Date: Mon, 06 Jul 2020 23:53:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner jwerner@chromium.org Gerrit-MessageType: comment

Julius Werner (Code Review)

8:53 p.m.

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42730 )

Change subject: trogdor: Add board variant checks in Kconfig ......................................................................

trogdor: Add board variant checks in Kconfig

Diffentiate Lazor and trogdor build configuration

Signed-off-by: Ravi Kumar Bokka rbokka@codeaurora.org Change-Id: I3ad413ea6e658e939796bebdff8c1e0dd76417cc Reviewed-on: https://review.coreboot.org/c/coreboot/+/42730 Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/trogdor/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved

diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index dfd98f0..0500574 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -5,7 +5,8 @@ if BOARD_GOOGLE_TROGDOR_COMMON

config TROGDOR_REV0 - def_bool y + def_bool y if BOARD_GOOGLE_TROGDOR + def_bool n

config BOARD_SPECIFIC_OPTIONS def_bool y

-- To view, visit https://review.coreboot.org/c/coreboot/+/42730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ad413ea6e658e939796bebdff8c1e0dd76417cc Gerrit-Change-Number: 42730 Gerrit-PatchSet: 5 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Manideep Kurumella mkurumel@qualcomm.corp-partner.google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: merged

1451

days inactive

1464

days old

coreboot-gerrit@coreboot.org

5 comments

2 participants

tags (0)

participants (2)

Julius Werner (Code Review)
Ravi kumar (Code Review)