Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/28803 )
Change subject: mb/google/poppy/variant/nocturne: increase touchscreen reset delay ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/28803/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/28803/1//COMMIT_MSG@9 PS1, Line 9: ms.
ms
Done
https://review.coreboot.org/#/c/28803/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/devicetree.cb:
https://review.coreboot.org/#/c/28803/1/src/mainboard/google/poppy/variants/... PS1, Line 294: register "generic.reset_delay_ms" = "10"
I think it would be good to add the "disable_gpio_export_in_crs" option as well.
Done