Attention is currently required from: Martin Roth, jacz@semihalf.com, Julius Werner, Jan Dabros.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49669 )
Change subject: tests: Add lib/region_file-test test case
......................................................................
Patch Set 4:
(1 comment)
File tests/include/tests/lib/region_file_data.h:
https://review.coreboot.org/c/coreboot/+/49669/comment/204f39a9_ab3fed55
PS3, Line 9: void array_dump(void *array, size_t length)
I agree with the statement that it looks slightly out of place, though I think it might be useful wh […]
with spinning out I meant moving it outside this file because it can be more generally useful (e.g. for other data files using this format)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic48e52a97b18d55fd983315f25dc972f472cc473
Gerrit-Change-Number: 49669
Gerrit-PatchSet: 4
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: jacz@semihalf.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 18:00:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: jacz@semihalf.com
Gerrit-MessageType: comment