Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78320?usp=email )
Change subject: Revert "mb/google/rex/var/screebo: Set `SAGV_POINTS_0_1_2` to avoid hang" ......................................................................
Revert "mb/google/rex/var/screebo: Set `SAGV_POINTS_0_1_2` to avoid hang"
This reverts commit 5c35d30ffc7382af46b62044a5cf5326b1e57708.
Reason for revert: Here we need to confirm whether the issue in mtl-staging-MTL.3323.92 has been improved in the QS sample in the factory build.
BUG=b:287170545 TEST=Able to idle for more than 5+ hours without any hang.
Change-Id: I4517bbbefe11d95623d7e16a5e4bba2dd6f408e1 Signed-off-by: Wentao Qin qinwentao@huaqin.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/78320 Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Mike Lee mike5@huaqin.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kapil Porwal kapilporwal@google.com --- M src/mainboard/google/rex/variants/screebo/overridetree.cb 1 file changed, 0 insertions(+), 3 deletions(-)
Approvals: Mike Lee: Looks good to me, but someone else must approve build bot (Jenkins): Verified Kapil Porwal: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index f2a9e55..06f7b9b 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -51,9 +51,6 @@ # Enable HDMI in Port B register "ddi_port_B_config" = "0"
- # TODO(b/287170545): workaround avoid DUT random hang - register "sagv_wp_bitmap" = "SAGV_POINTS_0_1_2" - # Enable Display Port Configuration register "ddi_ports_config" = "{ [DDI_PORT_A] = DDI_ENABLE_HPD,